Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor/service account create #5399

Merged
merged 2 commits into from
Jan 3, 2025
Merged

Conversation

kkdy21
Copy link
Contributor

@kkdy21 kkdy21 commented Jan 3, 2025

To Reviewers

  • Self-reviewed (coding conventions, bug-free, functionality verified, tests checked, documentation updated)
  • Minor change, review optional (style, chore, ci, straightforward changes, etc.)
  • Previously reviewed in feature branch, no further review needed
  • Need review or discussion

Description (optional)

Things to Talk About (optional)

* refactor: split createAccount logic for better modularity

Signed-off-by: daeyeon ko <[email protected]>

* refactor: error handling

Signed-off-by: daeyeon ko <[email protected]>

---------

Signed-off-by: daeyeon ko <[email protected]>
Copy link

vercel bot commented Jan 3, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
dashboard ⬜️ Ignored (Inspect) Jan 3, 2025 6:10am
inventory-v2 ⬜️ Ignored (Inspect) Jan 3, 2025 6:10am

@kkdy21 kkdy21 merged commit 9ad2ea9 into master Jan 3, 2025
9 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant