fix: fixed qa bug #5554
Merged
fix: fixed qa bug #5554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: NaYeong,Kim <[email protected]>
Signed-off-by: NaYeong,Kim <[email protected]>
skdud4659
added
the
self_approved/review
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
skdud4659
merged commit 28645a4
into
cloudforet-io:feature-project-alert-manager
8 checks passed
skdud4659
added a commit
that referenced
this pull request
Jan 20, 2025
* ci: add check for PR author organization membership and assign them (#5521) * chore: for ci test Signed-off-by: Wanjin Noh <[email protected]> * ci: add check for PR author organization membership and assign them Signed-off-by: Wanjin Noh <[email protected]> * ci: update pull request review labeler to handle reopened events Signed-off-by: Wanjin Noh <[email protected]> * ci: enhance pull request review labeler to handle missing review state Signed-off-by: Wanjin Noh <[email protected]> --------- Signed-off-by: Wanjin Noh <[email protected]> * chore: ci test (#5522) Signed-off-by: Wanjin Noh <[email protected]> * fix(reference-store): correct logic for selecting fetcher based on version (#5536) - Inverted the condition for determining the collector and region fetchers - Ensured correct API client is used based on alert manager version Signed-off-by: sulmo <[email protected]> * chore: changed css (#5537) Signed-off-by: NaYeong,Kim <[email protected]> * feat: apply qa and additional requests (#5552) * chore: changed icon color Signed-off-by: NaYeong,Kim <[email protected]> * feat: create alert creation button at service page Signed-off-by: NaYeong,Kim <[email protected]> * feat: update history error modal Signed-off-by: NaYeong,Kim <[email protected]> * feat: create app reference store and apply app name at timeline Signed-off-by: NaYeong,Kim <[email protected]> * feat: apply resource link at alert detail page Signed-off-by: NaYeong,Kim <[email protected]> * feat: apply 'user group' text at member modal Signed-off-by: NaYeong,Kim <[email protected]> * feat: apply raw data modal at webhook error tab Signed-off-by: NaYeong,Kim <[email protected]> * fix: fixed timeline bug Signed-off-by: NaYeong,Kim <[email protected]> * feat: apply filter retention Signed-off-by: NaYeong,Kim <[email protected]> * chore: changed translations and style Signed-off-by: NaYeong,Kim <[email protected]> * feat: changed create alert button position Signed-off-by: NaYeong,Kim <[email protected]> * feat: fixed condition form bug and translate operator Signed-off-by: NaYeong,Kim <[email protected]> * chore: translations Signed-off-by: NaYeong,Kim <[email protected]> --------- Signed-off-by: NaYeong,Kim <[email protected]> * fix: fixed qa bug (#5554) * fix: fixed minor bug (timeline) Signed-off-by: NaYeong,Kim <[email protected]> * fix: fixed qa bug Signed-off-by: NaYeong,Kim <[email protected]> --------- Signed-off-by: NaYeong,Kim <[email protected]> * feat: apply sort (#5555) Signed-off-by: NaYeong,Kim <[email protected]> --------- Signed-off-by: Wanjin Noh <[email protected]> Signed-off-by: sulmo <[email protected]> Signed-off-by: NaYeong,Kim <[email protected]> Co-authored-by: WANJIN <[email protected]> Co-authored-by: sulmo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To Reviewers
style,chore,ci,test,docs)Description (optional)
SSIA
Things to Talk About (optional)