Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: reflect the latest changes in composable to the queryInput #5575

Merged
merged 1 commit into from
Jan 21, 2025

Conversation

sulmoJ
Copy link
Member

@sulmoJ sulmoJ commented Jan 21, 2025

Skip Review (optional)

  • Minor changes that don't affect the functionality (e.g. style, chore, ci, test, docs)
  • Previously reviewed in feature branch, further review is not mandatory
  • Self-merge allowed for solo developers or urgent changes

Description (optional)

The issue occurred because the changes made to the useContextMenuStyle composable were not reflected in PQueryItem.

Things to Talk About (optional)

- Reordered `targetRef`, `menuRef`, and `inputRef` declarations
- Passed `targetRef` and `menuRef` to `useContextMenuStyle` function

Signed-off-by: sulmo <[email protected]>
Copy link

vercel bot commented Jan 21, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
console ⬜️ Ignored (Inspect) Jan 21, 2025 10:33am
dashboard ⬜️ Ignored (Inspect) Jan 21, 2025 10:33am
inventory-v2 ⬜️ Ignored (Inspect) Jan 21, 2025 10:33am

@github-actions github-actions bot added pending/review Pull Request is awaiting review. No reviewers have started reviewing yet. pass/signedoff labels Jan 21, 2025
Copy link
Member

@WANZARGEN WANZARGEN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

@github-actions github-actions bot added approved/review Pull Request has been approved. All reviewers have signed off and no further changes are required. and removed pending/review Pull Request is awaiting review. No reviewers have started reviewing yet. labels Jan 21, 2025
@sulmoJ sulmoJ merged commit d41f58f into master Jan 21, 2025
12 checks passed
@github-actions github-actions bot removed the approved/review Pull Request has been approved. All reviewers have signed off and no further changes are required. label Jan 21, 2025
@sulmoJ sulmoJ deleted the hotfix-query-input branch January 21, 2025 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants