Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: apply qa issue #5584

Conversation

seungyeoneeee
Copy link
Contributor

Skip Review (optional)

  • Minor changes that don't affect the functionality (e.g. style, chore, ci, test, docs)
  • Previously reviewed in feature branch, further review is not mandatory
  • Self-merge allowed for solo developers or urgent changes

Description (optional)

Things to Talk About (optional)

Copy link

vercel bot commented Jan 21, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
console ⬜️ Ignored (Inspect) Visit Preview Jan 21, 2025 3:25pm
dashboard ⬜️ Ignored (Inspect) Visit Preview Jan 21, 2025 3:25pm

@github-actions github-actions bot added pending/review Pull Request is awaiting review. No reviewers have started reviewing yet. pass/signedoff labels Jan 21, 2025
Copy link
Contributor

🎉 @skdud4659 and @kkdy21 have been randomly selected as the reviewers! Please review. 🙏

@github-actions github-actions bot requested a review from kkdy21 January 21, 2025 15:25
@seungyeoneeee seungyeoneeee added self_approved/review Pull Request has been reviewed and approved by the author without requiring additional reviewers. and removed pending/review Pull Request is awaiting review. No reviewers have started reviewing yet. labels Jan 21, 2025
@seungyeoneeee seungyeoneeee removed the request for review from kkdy21 January 21, 2025 15:28
Copy link
Member

@skdud4659 skdud4659 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@seungyeoneeee seungyeoneeee merged commit f36f8ab into cloudforet-io:feature-project-alert-manager Jan 22, 2025
10 checks passed
@seungyeoneeee seungyeoneeee deleted the feature/alert-qa-0122 branch January 22, 2025 01:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pass/signedoff self_approved/review Pull Request has been reviewed and approved by the author without requiring additional reviewers.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants