Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge to master (alert manager v2) #5598

Merged
merged 4 commits into from
Jan 22, 2025
Merged

merge to master (alert manager v2) #5598

merged 4 commits into from
Jan 22, 2025

Conversation

skdud4659
Copy link
Member

Skip Review (optional)

  • Minor changes that don't affect the functionality (e.g. style, chore, ci, test, docs)
  • Previously reviewed in feature branch, further review is not mandatory
  • Self-merge allowed for solo developers or urgent changes

Description (optional)

apply minor qa issue

Things to Talk About (optional)

skdud4659 and others added 4 commits January 22, 2025 14:25
Signed-off-by: NaYeong,Kim <[email protected]>
remove webhook that duplicated with triggered by & divide badge type of triggered type

Signed-off-by: 이승연 <[email protected]>
@skdud4659 skdud4659 added the self_approved/review Pull Request has been reviewed and approved by the author without requiring additional reviewers. label Jan 22, 2025
Copy link

vercel bot commented Jan 22, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
console ⬜️ Ignored (Inspect) Jan 22, 2025 5:57am
dashboard ⬜️ Ignored (Inspect) Jan 22, 2025 5:57am
inventory-v2 ⬜️ Ignored (Inspect) Jan 22, 2025 5:57am

Copy link
Contributor

⚠️ @skdud4659 the signed-off-by was not found in the following 1 commits:

✅ Why it is required

The Developer Certificate of Origin (DCO) is a lightweight way for contributors to certify that they wrote or otherwise have the right to submit the code they are contributing to the project. Here is the full text of the DCO.

Contributors sign-off that they adhere to these requirements by adding a Signed-off-by line to commit messages.

This is my commit message

Signed-off-by: Random Developer <[email protected]>

Git even has a -s command line option to append this automatically to your commit message:

$ git commit -s -m 'This is my commit message'

@skdud4659 skdud4659 merged commit 953e2bf into master Jan 22, 2025
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fail/signedoff self_approved/review Pull Request has been reviewed and approved by the author without requiring additional reviewers.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants