Refactor Region service #12
Conversation
Signed-off-by: lhhyung <[email protected]>
Signed-off-by: lhhyung <[email protected]>
|
✅ Why it is requiredThe Developer Certificate of Origin (DCO) is a lightweight way for contributors to certify that they wrote or otherwise have the right to submit the code they are contributing to the project. Here is the full text of the DCO. Contributors sign-off that they adhere to these requirements by adding a Git even has a |
lhhyung
added
enhancement
Signed-off-by: lhhyung <[email protected]>
Signed-off-by: lhhyung <[email protected]>
|
✅ Why it is requiredThe Developer Certificate of Origin (DCO) is a lightweight way for contributors to certify that they wrote or otherwise have the right to submit the code they are contributing to the project. Here is the full text of the DCO. Contributors sign-off that they adhere to these requirements by adding a Git even has a |
|
✅ Why it is requiredThe Developer Certificate of Origin (DCO) is a lightweight way for contributors to certify that they wrote or otherwise have the right to submit the code they are contributing to the project. Here is the full text of the DCO. Contributors sign-off that they adhere to these requirements by adding a Git even has a |
Signed-off-by: lhhyung <[email protected]>
|
✅ Why it is requiredThe Developer Certificate of Origin (DCO) is a lightweight way for contributors to certify that they wrote or otherwise have the right to submit the code they are contributing to the project. Here is the full text of the DCO. Contributors sign-off that they adhere to these requirements by adding a Git even has a |
Signed-off-by: lhhyung <[email protected]>
|
✅ Why it is requiredThe Developer Certificate of Origin (DCO) is a lightweight way for contributors to certify that they wrote or otherwise have the right to submit the code they are contributing to the project. Here is the full text of the DCO. Contributors sign-off that they adhere to these requirements by adding a Git even has a |
Signed-off-by: lhhyung <[email protected]>
|
✅ Why it is requiredThe Developer Certificate of Origin (DCO) is a lightweight way for contributors to certify that they wrote or otherwise have the right to submit the code they are contributing to the project. Here is the full text of the DCO. Contributors sign-off that they adhere to these requirements by adding a Git even has a |
…e method in Region Service Signed-off-by: lhhyung <[email protected]>
|
✅ Why it is requiredThe Developer Certificate of Origin (DCO) is a lightweight way for contributors to certify that they wrote or otherwise have the right to submit the code they are contributing to the project. Here is the full text of the DCO. Contributors sign-off that they adhere to these requirements by adding a Git even has a |
|
|
||
| class RegionUpdateRequest(BaseModel): | ||
| region_id: str | ||
| name: str = None |
There was a problem hiding this comment.
This field is optional. As our convention, it is recommended that it be of type Union[str, None].
| ) | ||
| def update(self, params: dict) -> Region: | ||
| @change_value_by_rule("APPEND", "workspace_id", "*") |
There was a problem hiding this comment.
I think I misinformed you; this decorator should only be used in the read operation.
| @change_value_by_rule("APPEND", "workspace_id", "*") |
| 'name': 'str', # required | ||
| 'region_code': 'str', # required | ||
| 'provider': 'str', # required | ||
| 'region_id': 'str, |
There was a problem hiding this comment.
region_id field has been removed from the RegionCreateRequest.
|
|
||
| return self.create_resource(params) | ||
| # return self.create_resource(params) |
There was a problem hiding this comment.
| # return self.create_resource(params) |
| if isinstance(params["tags"], list): | ||
| params["tags"] = utils.tags_to_dict(params["tags"]) | ||
|
|
||
| identity_mgr = IdentityManager() |
There was a problem hiding this comment.
| identity_mgr = IdentityManager() |
| ) | ||
| def delete(self, params: dict) -> None: | ||
| @change_value_by_rule("APPEND", "workspace_id", "*") |
There was a problem hiding this comment.
| @change_value_by_rule("APPEND", "workspace_id", "*") |
| region_id: str | ||
| name: str = None | ||
| tags: Union[dict, None] = None | ||
| workspace_id: Union[list, str, None] = None |
There was a problem hiding this comment.
| workspace_id: Union[list, str, None] = None | |
| workspace_id: Union[str, None] = None |
|
|
||
| class RegionDeleteRequest(BaseModel): | ||
| region_id: str | ||
| workspace_id: Union[list, str, None] = None |
There was a problem hiding this comment.
| workspace_id: Union[list, str, None] = None | |
| workspace_id: Union[str, None] = None |
Signed-off-by: lhhyung <[email protected]>
|
✅ Why it is requiredThe Developer Certificate of Origin (DCO) is a lightweight way for contributors to certify that they wrote or otherwise have the right to submit the code they are contributing to the project. Here is the full text of the DCO. Contributors sign-off that they adhere to these requirements by adding a Git even has a |
…thods Signed-off-by: lhhyung <[email protected]>
|
✅ Why it is requiredThe Developer Certificate of Origin (DCO) is a lightweight way for contributors to certify that they wrote or otherwise have the right to submit the code they are contributing to the project. Here is the full text of the DCO. Contributors sign-off that they adhere to these requirements by adding a Git even has a |
…equest Signed-off-by: lhhyung <[email protected]>
|
✅ Why it is requiredThe Developer Certificate of Origin (DCO) is a lightweight way for contributors to certify that they wrote or otherwise have the right to submit the code they are contributing to the project. Here is the full text of the DCO. Contributors sign-off that they adhere to these requirements by adding a Git even has a |
Category
Description
Refactor Region service
Known issue