Feature: refactor the service broker to the CF SB API v2.4 #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To fix: > No qualifying bean of type [org.cloudfoundry.community.servicebroker.s3.plan.Plan] > is defined: expected single matching bean but found 2: sharedPlan,basicPlan
NOTE: the tests are now failing because the BasicPlan tries to create the same user in parallel.
…maven manifest So we can trace back from which commit a jar was built.
This is needed for 'Try-with-resources' support: https://docs.oracle.com/javase/tutorial/essential/exceptions/tryResourceClose.html
S3Object opens a connection for each object. These connections are not liberated even if the object is garbage collected, so it is needed to execute either use Try-with-resources (preferred) or manually call object.close() in order to liberate the connection to the pool. Failing to do so will result in AmazonClientException: ConnectionPoolTimeoutException. More information can be found here: - http://stackoverflow.com/questions/17782937/connectionpooltimeoutexception-when-iterating-objects-in-s3 - https://forums.aws.amazon.com/message.jspa?messageID=471149 - https://java.awsblog.com/post/Tx22D24MCRWFR9U/Closeable-S3Objects - http://docs.aws.amazon.com/AWSJavaSDK/latest/javadoc/com/amazonaws/services/s3/model/S3Object.html
This is done to ensure that the Javadoc on S3.getObject(GetObjectRequest getObjectRequest) is read, and also because it's more consistent with the rest of the codebase.
…eption fix for S3Object ConnectionPoolTimeoutException
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.