-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(feat) Add XFCC authenticated scaling engine endpoint #3320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bonzofenix
force-pushed
the
add-cf-endpoint-to-scaling-engine
branch
2 times, most recently
from
November 13, 2024 13:07
298d79a
to
a1d0bd6
Compare
bonzofenix
added
the
allow-acceptance-tests
This label needs to be added to enable the acceptance tests to run.
label
Nov 13, 2024
bonzofenix
force-pushed
the
add-cf-endpoint-to-scaling-engine
branch
14 times, most recently
from
November 13, 2024 22:49
c74ad60
to
2ef9a85
Compare
bonzofenix
changed the title
Add cf endpoint to scaling engine
(feat) Add XFCC authenticated endpoint to scaling engine service
Nov 14, 2024
bonzofenix
force-pushed
the
add-cf-endpoint-to-scaling-engine
branch
2 times, most recently
from
November 14, 2024 10:16
90fe189
to
98442f6
Compare
bonzofenix
changed the title
(feat) Add XFCC authenticated endpoint to scaling engine service
(feat) Add XFCC authenticated endpoint for scaling engine service
Nov 14, 2024
bonzofenix
changed the title
(feat) Add XFCC authenticated endpoint for scaling engine service
(feat) Add XFCC authenticated scaling engine endpoint
Nov 14, 2024
bonzofenix
force-pushed
the
add-cf-endpoint-to-scaling-engine
branch
2 times, most recently
from
November 18, 2024 12:13
0bdb2c9
to
a427b67
Compare
silvestre
reviewed
Nov 19, 2024
bonzofenix
force-pushed
the
add-cf-endpoint-to-scaling-engine
branch
2 times, most recently
from
November 21, 2024 12:30
29d66c0
to
9dcb3fd
Compare
bonzofenix
force-pushed
the
add-cf-endpoint-to-scaling-engine
branch
2 times, most recently
from
November 25, 2024 14:48
532722b
to
1875d2e
Compare
bonzofenix
commented
Nov 25, 2024
Co-authored-by: Silvestre Zabala <[email protected]>
Co-authored-by: Silvestre Zabala <[email protected]>
bonzofenix
force-pushed
the
add-cf-endpoint-to-scaling-engine
branch
from
November 27, 2024 12:36
1875d2e
to
ca3f8c5
Compare
Quality Gate passedIssues Measures |
silvestre
approved these changes
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds a new xfcc unified endpoint to the scaling engine that will be consumed by the API component once it is deployed as a Cloud Foundry application.
includes several changes to the
deploy-autoscaler.sh
script, configuration files, and tests related to the autoscaler deployment and CF server configurations. The most important changes include refactoring thedeploy-autoscaler.sh
script for better readability and maintainability, adding new CF server configurations, and updating tests to reflect these changes.Script Refactoring:
deploy-autoscaler.sh
. [1] [2]Configuration Updates:
jobs/scalingengine/spec
.scalingengine.yml.erb
template to include new CF server properties.use-cf-services.yml
to add space and org GUIDs to the scaling engine.Test Updates:
scalingengine_spec.rb
to include checks for the new CF server configurations.GetServer
toCreateServer
inbroker_server.go
and updated corresponding tests. [1] [2] [3]api_test.go
. [1] [2] [3] [4]