chore: Refactor and rebuild binary asset #187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaces build_app.sh with Makefile to make the script more lightweight and clear. It seems like the goal of the build_app.sh script is to build a new app using the GOOS, GOARCH, and Go version associated with the cf-d-c-t image. While that is somewhat useful its limited because that image doesn't necessarily reflect the cflinuxfs that the app will be pushed to. I think that its goals can all be accomplished by specifying the values as env vars in a Makefile and using the new forward/backward compatibility in Go. This Makefile also does not depend upon docker and runs much faster. Also turned off cgo with `CGO_ENABLED=0` to make the binary static.
Trivially renames the executable. If `-o` is not specified in `go build` then the package name is used for the executable, which in this case is `binary`. Prefer that to renaming the executable.
davewalter
approved these changes
Sep 25, 2024
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this change about?
build_app.shwith a lighter-weightMakefile.Please provide contextual information.
None.
Please check all that apply for this PR:
Did you update the README as appropriate for this change?
How should this change be described in release notes?
Rebuild binary asset.
What is the level of urgency for publishing this change?
Tag your pair, your PM, and/or team!
None