[RFC] Add criteria and define a removal process for inactive users #707

beyhan · 2023-10-25T13:18:34Z

stephanme · 2023-10-31T12:44:52Z

toc/rfc/rfc-draft-define-criteria-and-removal-process-for-inactive-members.md

+
+The period to analyze should be the last 12 months and following criteria should be use to identify inactive users:
+* No contributions to the Cloud Foundry Github organization repositories
+* No participations in working group activities


Do we want the same rules for reviewers and approvers? Or is a dedicated WG role treated as "participation in WG activities"?

My intention was to describe any activity which can be executed as CFF contributor. It should be independent of the WG role. Regarding the period in the past which should be taken in the account I think having the same is ok.

Can make it explicit that this RFC is not about working group reviewers or approvers?

stephanme · 2023-10-31T12:49:04Z

toc/rfc/rfc-draft-define-criteria-and-removal-process-for-inactive-members.md

+### Criteria for Inactive Members
+
+The period to analyze should be the last 12 months and following criteria should be use to identify inactive users:
+* No contributions to the Cloud Foundry Github organization repositories


Contribution = merged commit, PR, issue, commenting on PR/issue, right?

yes. Should we clarify it more concrete?

Let's be more concrete.

stephanme · 2023-10-31T13:04:06Z

toc/rfc/rfc-draft-define-criteria-and-removal-process-for-inactive-members.md

+
+### Remove the membership to the Cloud Foundry Github Organization
+
+If the inactivity criteria are fulfilled for a member they should be removed from the Cloud Foundry Github organization. Any automation, approver or TOC member may submit a PR to remove the member from the Cloud Foundry Github organization. The person whose membership is being removed must be given two weeks to refute the removal. The working group lead to which the member belongs or TOC in case the member doesn't belong to any working group must make the final decision to remove the membership by merging the PR.


The initial cleanup will have to handle several hundreds inactive users. I guess we want to allow bulk PRs that remove many members at once, at least for the initial cleanup.

Good catch! I added a new section about this. Is it ok like this?

ameowlia

Can you add a section on what tool you plan to use to do this?

ameowlia · 2023-10-31T16:26:06Z

toc/rfc/rfc-draft-define-criteria-and-removal-process-for-inactive-members.md

+### Criteria for Inactive Members
+
+The period to analyze should be the last 12 months and following criteria should be use to identify inactive users:
+* No contributions to the Cloud Foundry Github organization repositories


Let's be more concrete.

ameowlia · 2023-10-31T16:27:11Z

toc/rfc/rfc-draft-define-criteria-and-removal-process-for-inactive-members.md

+
+The period to analyze should be the last 12 months and following criteria should be use to identify inactive users:
+* No contributions to the Cloud Foundry Github organization repositories
+* No participations in working group activities


Can make it explicit that this RFC is not about working group reviewers or approvers?

beyhan · 2023-11-14T11:44:08Z

@ameowlia all your comments should got addressed in the latest version. Let's have another review iteration :-).

beyhan · 2023-11-14T14:33:01Z

I did research about what tools exist and results are:

I found that the CNCF is using the devstats project to aggregate activity data and open issues like this to cleanup the members. The pr seems to be a manual action based on data from their devstats dashbaord which is a deployment of the devstats project.
Github action https://github.com/peter-murray/inactive-users-action which seems to out of maintenance
Gist with code to list all inactive users https://gist.github.com/psa-jforestier/28a5de5d262ac2af5b00595e651696d0
Our own script to list the contributions of a user https://github.com/cloudfoundry/community/blob/main/toc/working-groups/contributions-for-user.sh
@christopherclark are there any LFX data which could be used here like the devstats in CNCF?

None of the above options is optimal but they could be used as a direction in case we implement our own thing.

ameowlia · 2023-11-14T15:50:11Z

Starting final comment period, which will end Tuesday November 21.

rkoster · 2023-11-14T19:39:39Z

A graphql query like the one below could be used:

query {
  user(login: "rkoster") {
    contributionsCollection(organizationID: "O_kgDOAAl8sg", from: "2022-11-14T15:00:00Z") {
      hasAnyContributions
    }
  }
}

Github API graphql explorer can be found here.

rkoster · 2023-11-14T19:46:29Z

Or as a single query for the org:

query {
  organization(login: "cloudfoundry") {
    membersWithRole(first: 50) {
      nodes {
        login
        contributionsCollection(organizationID: "O_kgDOAAl8sg") {
          hasAnyContributions
        }
      }
    }
  }
}

Needs pagination

anita-flegg · 2023-11-16T14:28:33Z

Looks good to me.

jochenehret · 2023-11-17T14:25:12Z

RFC looks good! I have only one wish: As the WG leads are responsible for their members, there should be an easy to use tool for checking the activity status according to this RFC.

beyhan · 2023-11-17T14:35:35Z

RFC looks good! I have only one wish: As the WG leads are responsible for their members, there should be an easy to use tool for checking the activity status according to this RFC.

@jochenehret There is a script available in this repository called contributions-for-user.sh which can be used. E.g. I used it to generate #680 (comment) and #660 (comment). It can generate all the contribution of a user for a WG. Does it full fill your expectations?

Already discussed

[RFC] Add criteria for inactive users

6dad2aa

beyhan force-pushed the add-rfc-for-inactive-cf-org-members branch from 760ae48 to 6dad2aa Compare October 25, 2023 13:20

beyhan changed the title ~~[WIP] [RFC] Add criteria for inactive users~~ [RFC] Add criteria for inactive users Oct 25, 2023

beyhan added the toc label Oct 25, 2023

beyhan requested review from a team, rkoster, stephanme, ameowlia and ChrisMcGowan and removed request for a team October 25, 2023 13:23

Add section for the criteria and the process

ad26695

beyhan changed the title ~~[RFC] Add criteria for inactive users~~ [RFC] Add criteria and define a removal process for inactive users Oct 25, 2023

stephanme reviewed Oct 31, 2023

View reviewed changes

Add a section for the initial cleanup

d64e89f

ameowlia previously requested changes Oct 31, 2023

View reviewed changes

Define contribution and address comments about implementation

157a57d

beyhan requested review from stephanme and ameowlia November 14, 2023 11:45

beyhan mentioned this pull request Nov 20, 2023

Implement inactive user management #713

Merged

stephanme approved these changes Nov 21, 2023

View reviewed changes

ChrisMcGowan approved these changes Nov 21, 2023

View reviewed changes

rkoster approved these changes Nov 21, 2023

View reviewed changes

beyhan merged commit f326a10 into main Nov 21, 2023

beyhan deleted the add-rfc-for-inactive-cf-org-members branch November 21, 2023 15:46

beyhan added a commit that referenced this pull request Nov 22, 2023

Assigning number 0025 to RFC from PR #707

7634317

beyhan added the rfc CFF community RFC label Feb 7, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[RFC] Add criteria and define a removal process for inactive users #707

[RFC] Add criteria and define a removal process for inactive users #707

beyhan commented Oct 25, 2023 •

edited

Loading

stephanme Oct 31, 2023

beyhan Oct 31, 2023

ameowlia Oct 31, 2023

beyhan Nov 14, 2023

stephanme Oct 31, 2023

beyhan Oct 31, 2023

ameowlia Oct 31, 2023

beyhan Nov 14, 2023

stephanme Oct 31, 2023

beyhan Oct 31, 2023

ameowlia left a comment

ameowlia Oct 31, 2023

ameowlia Oct 31, 2023

beyhan commented Nov 14, 2023 •

edited

Loading

beyhan commented Nov 14, 2023

ameowlia commented Nov 14, 2023

rkoster commented Nov 14, 2023

rkoster commented Nov 14, 2023 •

edited

Loading

anita-flegg commented Nov 16, 2023

jochenehret commented Nov 17, 2023

beyhan commented Nov 17, 2023 •

edited

Loading


		### Remove the membership to the Cloud Foundry Github Organization

		If the inactivity criteria are fulfilled for a member they should be removed from the Cloud Foundry Github organization. Any automation, approver or TOC member may submit a PR to remove the member from the Cloud Foundry Github organization. The person whose membership is being removed must be given two weeks to refute the removal. The working group lead to which the member belongs or TOC in case the member doesn't belong to any working group must make the final decision to remove the membership by merging the PR.

[RFC] Add criteria and define a removal process for inactive users #707

[RFC] Add criteria and define a removal process for inactive users #707

Conversation

beyhan commented Oct 25, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ameowlia left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

beyhan commented Nov 14, 2023 • edited Loading

beyhan commented Nov 14, 2023

ameowlia commented Nov 14, 2023

rkoster commented Nov 14, 2023

rkoster commented Nov 14, 2023 • edited Loading

anita-flegg commented Nov 16, 2023

jochenehret commented Nov 17, 2023

beyhan commented Nov 17, 2023 • edited Loading

beyhan commented Oct 25, 2023 •

edited

Loading

beyhan commented Nov 14, 2023 •

edited

Loading

rkoster commented Nov 14, 2023 •

edited

Loading

beyhan commented Nov 17, 2023 •

edited

Loading