fix: Contrast (Minimum) (WCAG SC 1.4.3) #817
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for cld-video-player ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for cld-vp-esm-pages ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
kalifyaniv-cloudinary
approved these changes
Feb 12, 2025
| @@ -108,8 +108,9 @@ export const overrideDefaultVideojsComponents = () => { | |||
| const Player = videojs.getComponent('Player'); | |||
| let children = Player.prototype.options_.children; | |||
|
|
|||
| // Add TitleBar as default | |||
| children.push('titleBar'); | |||
| if (children.indexOf('titleBar') === -1) { | |||
There was a problem hiding this comment.
I was playing with colors opacity, and got weird results visually, this is how I found out the title is being rendered twice :)
This if prevents that.
There was a problem hiding this comment.
@ShayLevi could this be what's failing the test here? I couldn't find any reason why it would fail, the videos obviously play fine in the deploy preview
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a few text color-contrast issues
Before:
After:
