-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Regex Update for New Resources in Terraform 0.12 #15
base: master
Are you sure you want to change the base?
Conversation
@eversC just a heads up ☝️ any suggestions? |
Taking a look For now, though, the test seems to fail:
|
Tests are failing? 🤔 When I run locally on that branch they pass:
|
@bgreg1012 you're right, I was running it on your master branch, which didn't have the 2nd commit 🤦 we should put this all in the makefile, but if you run
I did a diff of the output of that on your branch, compared to |
@bgreg1012 were you able to take a look at this? |
I can confirm with @eversC there's a regression Please note that running |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please check tests in tests/
folder as they are leaking secrets
Hi @bgreg1012 , thanks for opening this - any chance you could look into the tests as mentioned by @osterman? |
Hi, I have a use-case in Terraform 0.12 where I'm adding new resources and I found that the reTfPlanLine regex wasn't capturing lines like:
+ token = "abC123ABc"
. To fix this I added another capture group in reTfPlanLine to match the scenario where-> ...
may not exist, and the logic to handle the different size capture groups.