Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docker build fixes #369

Merged
merged 5 commits into from
Jan 26, 2024
Merged

Docker build fixes #369

merged 5 commits into from
Jan 26, 2024

Conversation

Nuru
Copy link
Contributor

@Nuru Nuru commented Jan 25, 2024 •
edited
Loading

what

  • Update tool versions
  • Force Docker build platform linux/amd64
  • Update docker and vhs workflows to use Node v20 actions
  • Add concurrency check to docker workflow

why

  • Stay current with features and bugfixes
  • Docker image is based on Alpine, and Cloud Posse packages for Alpine are only available for amd64 (no ARM support)
  • Node 16 is deprecated
  • Cancel builds that are superseded

@Nuru Nuru requested a review from osterman January 25, 2024 23:02
@Nuru Nuru requested review from a team as code owners January 25, 2024 23:02
@Nuru Nuru requested review from dotCipher and joe-niland January 25, 2024 23:02
@github-actions github-actions bot requested review from aknysh and goruha January 25, 2024 23:02
@Nuru Nuru enabled auto-merge (squash) January 25, 2024 23:03
osterman
osterman previously approved these changes Jan 25, 2024
View reviewed changes
@Nuru Nuru requested a review from osterman January 25, 2024 23:29
@Nuru Nuru merged commit 2cfc93f into master Jan 26, 2024
12 of 14 checks passed
@Nuru Nuru deleted the docker-build-fixes branch January 26, 2024 02:05
osterman pushed a commit that referenced this pull request Jan 26, 2024
@Nuru @osterman
Update tool versions, fix Docker build on Apple Silicon (#369)
3f18ad2
@Nuru Nuru mentioned this pull request Jan 26, 2024
Merged
osterman added a commit that referenced this pull request Jan 30, 2024
@osterman @actions-user @Nuru
Use Organization's .github README.md.gotmpl (#368)
56cac58 
* Fetch org readme template

* chore: update repo banner image

* fetch template from main

* add safe directory for git

* add safe directory for git

* add safe directory for git

* test fix

* test fix

* test fix

* test fix

* test fix

* test fix

* test fix

* test fix

* use make native

* fix lint error

* bump checkout

* bump checkout and do not ignore .git

* Update tool versions, fix Docker build on Apple Silicon (#369)

* formatting

* remove -# syntax=docker/dockerfile:1.3

* move README_TEMPLATE_YAML dep and check for .git

* Update lint for security

* Restrict README template to whitelisted orgs

* terminology

* Do not allow override of remote URL

* Fix (spurious) lint complaint

* Better error message

---------

Co-authored-by: screenshot-action 📷 <[email protected]>
Co-authored-by: Nuru <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@osterman osterman osterman approved these changes

@dotCipher dotCipher Awaiting requested review from dotCipher dotCipher is a code owner automatically assigned from cloudposse/contributors

@joe-niland joe-niland Awaiting requested review from joe-niland joe-niland is a code owner automatically assigned from cloudposse/contributors

@aknysh aknysh Awaiting requested review from aknysh

@goruha goruha Awaiting requested review from goruha

Assignees

@Nuru Nuru

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Nuru @osterman @actions-user