Fix Excessive CPU usage, fix --solo

[Nuru]

what

• Fix shell monitoring introduced in v4.1.0 Better tracking of shells and terminal colors, and other internal improvements #970
• Fix --solo / ONE_SHELL=true option broken in v4.1.0 Better tracking of shells and terminal colors, and other internal improvements #970

why

• Bug caused shell monitor to burn CPU busy waiting on shell exits rather than sleep and poll
• Oversight in refactoring launch vs exec parameters left out terminal allocation for --solo option, causing Geodesic to immediately exit

[coderabbitai]

📝 Walkthrough

Walkthrough

This pull request introduces two main changes. In the Docker container wrapper script, a new conditional check is added to append the -it option to Docker execution arguments when standard input is a terminal. Additionally, the shell-monitor script has been refactored by replacing the count_shells function with shells_are_running, updating naming conventions, and enhancing the clarity of the code. These modifications adjust how interactive sessions and active shell checks are handled without changing the overall behavior of the applications.

Changes

File(s)	Summary
rootfs/templates/wrapper-body.sh	Adds a conditional statement within the use function to check if standard input is a terminal ([ -t 0 ]) and, if true, appends the -it option to the DOCKER_EXEC_ARGS array for interactive Docker container sessions.
rootfs/usr/local/sbin/shell-monitor	Refactors active shell checking by replacing count_shells with shells_are_running (returning a boolean) and renaming list_wrapper_shells to list-wrapper-shells; enhances code readability and includes comments for clarity.

Possibly related PRs

• V4 second bugfixes #969: Addresses similar modifications in wrapper-body.sh related to command-line options and workspace management, establishing a strong code-level connection.

---

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ab2917d and 455ada4.

📒 Files selected for processing (1)

• rootfs/usr/local/sbin/shell-monitor (4 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

• rootfs/usr/local/sbin/shell-monitor

⏰ Context from checks skipped due to timeout of 90000ms (1)

• GitHub Check: build-and-push (debian)

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.