Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initialize attached windows disks in Azure ARM #35

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ivanayov
Copy link
Contributor

No description provided.

@ivanayov ivanayov force-pushed the feature/arm-initialize-disk-win branch 4 times, most recently from 69d8022 to adf218b Compare July 12, 2017 15:39
@ivanayov ivanayov changed the title [WIP] Implement attached windows disk initialization in Azure ARM Implement attached windows disk initialization in Azure ARM Jul 12, 2017
@ivanayov ivanayov changed the title Implement attached windows disk initialization in Azure ARM Initialize attached windows disks in Azure ARM Jul 12, 2017
@ivanayov ivanayov force-pushed the feature/arm-initialize-disk-win branch from adf218b to 326f78d Compare July 13, 2017 21:13
@bostko
Copy link
Contributor

bostko commented Jul 25, 2017

Looks good although didn't tested it.

machine, osDeviceName, filesystemType));
}
} else if (machine instanceof WinRmMachineLocation) {
WinRmToolResponse response = ((WinRmMachineLocation)machine).executePsScript("Get-Disk | Where partitionstyle -eq 'raw' | " +
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could format a disk which you should not format this way.
I prefer passing explicit disk letter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants