Send input to the remote command asynchronously #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to thread safety AddressingProperties was shared between all requests, making it impossible to use the same WinRmClient concurrently. It stores things like the current action name (which we had to update because it takes the first one otherwise), the message id. We needed that so we can force CXF into using the 2004 version of the addressing namespace. The changes here take a different approach (creating a policy and setting a special assertion on it), causing CXF to create the AddressingProperties object per request.
|
I've posted a question to SO, describing the problem with blocking input - https://stackoverflow.com/questions/45349118/windows-2012r2-doesnt-accept-input-from-winrs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on the @semancik's prototype in issue #53.
Depends on #65 because uses
WinRmClientconcurrently.Successfully tested against Windows 7.
Failed to get it working against Windows Server 2012R2. Sending any input blocks and the process never receives it. I've been able to replicate with the Windows'
winrstool which blocks in a similar way, suggesting it's not an implementation incompatibility, but a server-side behaviour.If I'm not able to get this working against Windows Server 2012R2, then I don't think it's worth merging this PR.