Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add featureGate IgnoreLeaseSync to stop sync leases.coordination.k8s.io #615

Merged
merged 1 commit into from
Dec 20, 2023

Conversation

27149chen
Copy link
Contributor

@27149chen 27149chen commented Dec 8, 2023

What type of PR is this?

/kind feature

What this PR does / why we need it:

This pr adds a featureGate IgnoreLeaseSync to stop synchronizing internal resources that the majority of users do not care about. Currently only leases.coordination.k8s.io is added since it updates too frequently.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Add a featureGate `SkipSyncLeases` to stop synchronizing `leases.coordination.k8s.io`

@clusterpedia-bot
Copy link

Hi @27149chen,
Thanks for your pull request!
If the PR is ready, use the /auto-cc command to assign Reviewer to Review.
We will review it shortly.

Details

Instructions for interacting with me using comments are available here.
If you have questions or suggestions related to my behavior, please file an issue against the gh-ci-bot repository.

@clusterpedia-bot clusterpedia-bot added the kind/feature New feature label Dec 8, 2023
Copy link
Member

@Iceber Iceber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rest looks good

// if the feature gate SkipSyncLeases is enabled.
var excludedInternalResources = sets.NewString(
"leases.coordination.k8s.io",
)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've made feature gates specific to the leases resource, so I don't think we need to maintain the excludedInternalResources here, we could add it if we need it more in the future

@Iceber
Copy link
Member

Iceber commented Dec 20, 2023

If there is more demand for skipping resource configurations in the future, then it may be necessary to add a --exclude-resources flag, but I don't think I'd really want to do that, because the people who use clusterpedia and the people who deploy clusterpedia may not be the same, and it's not appropriate to silently skip some resources.

In the future it is still recommended to exclude resources on PediaCluster. #617

This pr allows users who have created a large number of pediaclusters to skip leases without modifying PediaCluster, which is a good value for existing users.

Copy link
Member

@Iceber Iceber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@27149chen 27149chen changed the title add featureGate SkipSyncInternalResources to stop sync leases.coordination.k8s.io add featureGate IgnoreLeaseSync to stop sync leases.coordination.k8s.io Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants