-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add featureGate IgnoreLeaseSync to stop sync leases.coordination.k8s.io #615
Conversation
Hi @27149chen, DetailsInstructions for interacting with me using comments are available here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The rest looks good
// if the feature gate SkipSyncLeases is enabled. | ||
var excludedInternalResources = sets.NewString( | ||
"leases.coordination.k8s.io", | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We've made feature gates specific to the leases resource, so I don't think we need to maintain the excludedInternalResources
here, we could add it if we need it more in the future
If there is more demand for skipping resource configurations in the future, then it may be necessary to add a In the future it is still recommended to exclude resources on PediaCluster. #617 This pr allows users who have created a large number of pediaclusters to skip leases without modifying PediaCluster, which is a good value for existing users. |
d2eb06a
to
8d63e45
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
8d63e45
to
348b47d
Compare
348b47d
to
b6eeea8
Compare
What type of PR is this?
/kind feature
What this PR does / why we need it:
This pr adds a featureGate
IgnoreLeaseSync
to stop synchronizing internal resources that the majority of users do not care about. Currently onlyleases.coordination.k8s.io
is added since it updates too frequently.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: