Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add type check for forcefield parameter in Simulation #118

Merged
merged 3 commits into from
Mar 8, 2024

Conversation

chrisjonesBSU
Copy link
Member

This PR adds and error that is thrown if the forcefield parameter of Simulation is not a sequence of hoomd.md.force.Force objects.

Copy link

codecov bot commented Mar 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.40%. Comparing base (e5d3de9) to head (84f57e6).
Report is 8 commits behind head on main.

❗ Current head 84f57e6 differs from pull request most recent head 5df13f7. Consider uploading reports for the commit 5df13f7 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #118      +/-   ##
==========================================
+ Coverage   94.38%   94.40%   +0.01%     
==========================================
  Files          25       25              
  Lines        1834     1840       +6     
==========================================
+ Hits         1731     1737       +6     
  Misses        103      103              
Files Coverage Δ
flowermd/base/simulation.py 91.64% <100.00%> (+0.15%) ⬆️

@chrisjonesBSU chrisjonesBSU merged commit 62f8363 into cmelab:main Mar 8, 2024
2 checks passed
@chrisjonesBSU chrisjonesBSU deleted the add-errors branch March 8, 2024 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants