Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change hoomd_polymers to hoomd_organics #26

Merged
merged 4 commits into from
Aug 24, 2023
Merged

Change hoomd_polymers to hoomd_organics #26

merged 4 commits into from
Aug 24, 2023

Conversation

marjanalbooyeh
Copy link
Collaborator

This PR updates all directory names, imports and strings from hoomd_polymers to hoomd_organics.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@chrisjonesBSU
Copy link
Member

Thanks for doing this! We still need to change the environment names in the yml files, and the directory names in codecov.yml

Copy link
Member

@chrisjonesBSU chrisjonesBSU left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@codecov
Copy link

codecov bot commented Aug 24, 2023

Codecov Report

❗ No coverage uploaded for pull request base (main@f17dc5c). Click here to learn what that means.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #26   +/-   ##
=======================================
  Coverage        ?   84.65%           
=======================================
  Files           ?       18           
  Lines           ?     1303           
  Branches        ?        0           
=======================================
  Hits            ?     1103           
  Misses          ?      200           
  Partials        ?        0           

@marjanalbooyeh marjanalbooyeh merged commit d888a16 into cmelab:main Aug 24, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Need to thoroughly check namechanges going to -organics from _polymers
2 participants