Skip to content
This repository has been archived by the owner on Jan 31, 2022. It is now read-only.

gemonlinedb tests crash on invalid XML file #308

Closed
1 of 2 tasks
lmoureaux opened this issue Nov 15, 2019 · 1 comment · Fixed by #309
Closed
1 of 2 tasks

gemonlinedb tests crash on invalid XML file #308

lmoureaux opened this issue Nov 15, 2019 · 1 comment · Fixed by #309
Assignees
@lmoureaux
Labels
Type: Bug Type: Maintenance

Comments

@lmoureaux
Copy link

Brief summary of issue

The tests for the gemonlinedb crash (SIGSEGV and/or SIGABRT) when one of the example XML files doesn't comply with the schema. Error reporting needs to be fixed.

Types of issue

  • Bug report (report an issue with the code)
  • Feature request (request for change which adds functionality)

Expected Behavior

Tests report failure but don't crash.

Current Behavior

Tests may crash on invalid input.

Steps to Reproduce (for bugs)

  1. Modify xml/examples/AMC13_Configuration.xml to not comply with the schema (eg by modifying the value of the NAME field)
  2. make run-tests

Context

Reviving gemonlinedb development.

Your Environment

  • Version used: current develop
  • Shell used: bash
@lmoureaux lmoureaux self-assigned this Nov 15, 2019
@lmoureaux
Copy link
Author

I think that this is caused by Xerces exceptions escaping the scope of a XercesGuard.

@lmoureaux lmoureaux mentioned this issue Nov 16, 2019
Merged
8 tasks
jsturdy added a commit that referenced this issue Nov 17, 2019
@jsturdy
Merge pull request #309 from lmoureaux/bugfix/more-robust-xerces-errors
4840cdd 
Fix tests crashing on invalid XML files

Closes #308
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@lmoureaux lmoureaux

Labels
Type: Bug Type: Maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix tests crashing on invalid XML files lmoureaux/cmsgemos
1 participant
@lmoureaux