This repository has been archived by the owner on Jan 31, 2022. It is now read-only.
Fix tests crashing on invalid XML files #309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tests were crashing when trying to load an XML file not complying with the schema. This was related to Xerces exceptions being thrown; replacing them with XDAQ exceptions fixes the problem. In addition, transcode() for Xerces strings was made more robust when the input string is null.
This adds a test for the issue fixed in the previous commit.
This was causing abort() to be called.
jsturdy
approved these changes
Nov 17, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix #308. The errors were caused by:
XercesGuarded areas: fixed by throwinggem::onlinedbexceptions fromXercesAlwaysThrowErrorManagerTypes of changes
Motivation and Context
#308
How Has This Been Tested?
Added a test for point 1. and ran tests locally with and without a broken
AMC13Configuraiton.xml.Checklist: