Skip to content
This repository has been archived by the owner on Jan 31, 2022. It is now read-only.

Add missing gemonlinedb/xml/tests/NonCompliantFile.json #323

Merged
merged 1 commit into from
Mar 18, 2020

Conversation

lmoureaux
Copy link

Description

Fix #322

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Motivation and Context

Fix #322

How Has This Been Tested?

Tests pass (well, it was already the case in my setup... a minimal #241 would have prevented this)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link
Contributor

@lpetre-ulb lpetre-ulb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All tests pass now! 👍

@mexanick mexanick merged commit 836faf7 into cms-gem-daq-project:develop Mar 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

gemonlinedb tests fail with a missing file
3 participants