This repository has been archived by the owner on Jan 31, 2022. It is now read-only.
in anaUltraScurve.py, TF1 associated with TTree branch should be copied into #213
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug was causing scurve fit branch to be corrupted in output tree.
Description
Currently, we are correctly handling the
scurve_h
branch but not thescurve_fit
branch:gem-plotting-tools/anaUltraScurve.py
Lines 581 to 583 in aacb46d
This pull request uses the same logic involving a holder to handle the
scurve_fit
branch as thescurve_h
branch.Types of changes
Motivation and Context
Currently, the
scurve_fit
branch stored in the output tree does not contain the scurve fit, and it will induce a crash if it is read from.A similar issue was reported #63, although it is not clear to me if that is actually address by this pull request.
How Has This Been Tested?
Yes, the bugfix was tested on GE11-X-S-PAK-0005 data taken by the QC8 team.
Screenshots (if appropriate):
Checklist: