Skip to content
This repository has been archived by the owner on Jan 31, 2022. It is now read-only.

in anaUltraScurve.py, TF1 associated with TTree branch should be copied into #213

Merged

Conversation

AndrewLevin
Copy link
Contributor

Bug was causing scurve fit branch to be corrupted in output tree.

Description

Currently, we are correctly handling the scurve_h branch but not the scurve_fit branch:

holder_curve = fitter.scanHistos[vfat][chan]
holder_curve.Copy(scurve_h)
scurve_fit = fitter.getFunc(vfat,chan).Clone('scurveFit_vfat%i_chan%i'%(vfat,chan))

This pull request uses the same logic involving a holder to handle the scurve_fit branch as the scurve_h branch.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Motivation and Context

Currently, the scurve_fit branch stored in the output tree does not contain the scurve fit, and it will induce a crash if it is read from.

A similar issue was reported #63, although it is not clear to me if that is actually address by this pull request.

How Has This Been Tested?

Yes, the bugfix was tested on GE11-X-S-PAK-0005 data taken by the QC8 team.

Screenshots (if appropriate):

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@jsturdy
Copy link
Contributor

jsturdy commented Jun 5, 2019

It appears that you are now out-of-date due to an illegal push by @bdorney 3db691e

@jsturdy jsturdy merged commit 5bbae9c into cms-gem-daq-project:develop Jun 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants