Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resources comparison: Compare absolute difference of fraction of total time per module #2371

Merged
merged 8 commits into from
Nov 20, 2024
Merged

Resources comparison: Compare absolute difference of fraction of total time per module #2371

merged 8 commits into from
Nov 20, 2024

Conversation

gartung
Copy link
Member

@gartung gartung commented Nov 13, 2024

No description provided.

@gartung
Squashed commit of the following commits:
f7f001f 
    commit e2d70cd
    Author: Patrick Gartung <[email protected]>
    Date:   Wed Nov 6 02:01:11 2024 +0100

        Rename input->prdata output->ibdata. Accumulate metrics by module type.

    commit 28e277c
    Author: Patrick Gartung <[email protected]>
    Date:   Tue Nov 5 22:17:55 2024 +0100

        Use fraction of total time for comparison. Some total time at top of table

    commit b077290
    Author: Patrick Gartung <[email protected]>
    Date:   Tue Nov 5 18:53:34 2024 +0100

        Try with scaled diffs
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @gartung for branch master.

@aandvalenzuela, @cmsbuild, @iarspider, @smuzaffar can you please review it and eventually sign? Thanks.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.
cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 13, 2024 •
edited
Loading

cms-bot internal usage

@gartung
Copy link
Member Author

gartung commented Nov 13, 2024

@smuzaffar is there any way to skip the Black formatting check other than fixing files not related to my change?

@gartung
Copy link
Member Author

gartung commented Nov 13, 2024

enable profiling

@makortel makortel mentioned this pull request Nov 13, 2024
Closed
@smuzaffar
Copy link
Contributor

@smuzaffar is there any way to skip the Black formatting check other than fixing files not related to my change?

@iarspider , remind me why we are running Black Style Check on full bot code instead of files changed by PR?

@smuzaffar
Copy link
Contributor

@gartung , I have fixed the formatting of other files but yes we should run the formatting check on only changed files. But lets wait for @iarspider , maybe I am missing something

@gartung
Copy link
Member Author

gartung commented Nov 13, 2024

It's not a blocking test anymore. I was able to start testing.

@smuzaffar
Copy link
Contributor

yes, formatting test does not block the normal PR tests

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4248f1/42817/summary.html
COMMIT: f7f001f
CMSSW: CMSSW_14_2_X_2024-11-13-1300/el8_amd64_gcc12
Additional Tests: PROFILING
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cms-bot/2371/42817/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 7 differences found in the comparisons
  • DQMHistoTests: Total files compared: 46
  • DQMHistoTests: Total histograms compared: 3343588
  • DQMHistoTests: Total failures: 387
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3343181
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 45 files compared)
  • Checked 202 log files, 172 edm output root files, 46 DQM output files
  • TriggerResults: no differences found

@cmsbuild
Copy link
Contributor

Pull request #2371 was updated.

@cmsbuild
Copy link
Contributor

Pull request #2371 was updated.

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4248f1/42866/summary.html
COMMIT: 0fc3e69
CMSSW: CMSSW_14_2_X_2024-11-14-1100/el8_amd64_gcc12
Additional Tests: PROFILING
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cms-bot/2371/42866/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 3 lines to the logs
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 46
  • DQMHistoTests: Total histograms compared: 3343764
  • DQMHistoTests: Total failures: 387
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3343357
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 45 files compared)
  • Checked 202 log files, 172 edm output root files, 46 DQM output files
  • TriggerResults: no differences found

@cmsbuild
Copy link
Contributor

Pull request #2371 was updated.

@cmsbuild
Copy link
Contributor

Pull request #2371 was updated.

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4248f1/42959/summary.html
COMMIT: 8a1b4e7
CMSSW: CMSSW_14_2_X_2024-11-19-1100/el8_amd64_gcc12
Additional Tests: PROFILING
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cms-bot/2371/42959/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@smuzaffar
Copy link
Contributor

@gartung , is this ready ?

@gartung
Copy link
Member Author

gartung commented Nov 20, 2024

yes

@smuzaffar
Copy link
Contributor

+externals

@smuzaffar smuzaffar merged commit 0c07414 into cms-sw:master Nov 20, 2024
12 of 13 checks passed
@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

@gartung gartung deleted the gartung-resources-diff branch November 20, 2024 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
externals-approved fully-signed orp-pending tests-pending
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gartung @cmsbuild @smuzaffar @jfernan2