Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test the g++ -fimplicit-constexpr option #9667

Open
wants to merge 1 commit into
base: IB/CMSSW_15_0_X/g13
Choose a base branch
from
Open

Test the g++ -fimplicit-constexpr option #9667

wants to merge 1 commit into from

Conversation

fwyzard
Copy link
Contributor

@fwyzard fwyzard commented Feb 2, 2025

From the GCC 12 manual:

-fimplicit-constexpr

Make inline functions implicitly constexpr, if they satisfy the requirements for a constexpr function. This option can be used in C++14 mode or later. This can result in initialization changing from dynamic to static and other optimizations.

@makortel noted that this flag makes the compilation very slow and memory consuming with GCC 12.x and 13.2, but is should be usable with GCC 13.3.

@fwyzard
Copy link
Contributor Author

fwyzard commented Feb 2, 2025

please test for el8_amd64_gcc13

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 2, 2025

A new Pull Request was created by @fwyzard for branch IB/CMSSW_15_0_X/g13.

@iarspider, @smuzaffar can you please review it and eventually sign? Thanks.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.
cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 2, 2025 •
edited
Loading

cms-bot internal usage

@smuzaffar
Copy link
Contributor

test parameters:

  • full_cmssw = true

@smuzaffar
Copy link
Contributor

please test for el8_amd64_gcc13

lets rebuild full cmssw

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 2, 2025

-1

Failed Tests: Build
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7813ab/44135/summary.html
COMMIT: fdb49d5
CMSSW: CMSSW_15_0_X_2025-01-31-2300/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/9667/44135/install.sh to create a dev area with all the needed externals and cmssw changes.

Build

I found compilation error when building:

>> Compiling  src/CondCore/DBOutputService/src/PoolDBOutputService.cc
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc13/external/gcc/13.3.1-92b2d78dc343ed2bc93c8eb414ddc9ff/bin/c++ -c -DCMS_MICRO_ARCH='x86-64-v3' -DGNU_GCC -D_GNU_SOURCE -DTBB_USE_GLIBCXX_VERSION=130301 -DTBB_SUPPRESS_DEPRECATED_MESSAGES -DTBB_PREVIEW_RESUMABLE_TASKS=1 -DTBB_PREVIEW_TASK_GROUP_EXTENSIONS=1 -DBOOST_SPIRIT_THREADSAFE -DPHOENIX_THREADSAFE -DBOOST_MATH_DISABLE_STD_FPCLASSIFY -DBOOST_UUID_RANDOM_PROVIDER_FORCE_POSIX -DCMSSW_GIT_HASH='CMSSW_15_0_X_2025-01-31-2300' -DPROJECT_NAME='CMSSW' -DPROJECT_VERSION='CMSSW_15_0_X_2025-01-31-2300' -Isrc -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc13/cms/coral/CORAL_2_3_21-efc1cdaf72cff32c6c1b98f0a233205b/include/LCG -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc13/external/pcre/8.43-98b91818238e6315baa782c93d2e1a8d/include -isystem/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc13/external/boost/1.80.0-219130170382a74ab026bc7e8f3aed50/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc13/external/bz2lib/1.0.6-f92c52f66bf6507988f946bd77fb689c/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc13/external/curl/7.79.0-a23d7bdb483609b91c18e4d97a98c4b0/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc13/external/libuuid/2.34-c2b49c79f52c48d7cb42b214bd8f95f6/include -isystem/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc13/lcg/root/6.32.09-673228292062580b5c2725e1de3085a5/include -isystem/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc13/external/tbb/v2021.9.0-fc977fda7ed4cc29c17d19c6703a0199/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc13/external/xerces-c/3.1.3-14d6230deabf01bcafd3d32c7a59dc27/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc13/external/xz/5.2.5-5f1d064218d21615d94b64b937b2e0b3/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc13/external/zlib/1.2.13-31c9b620a337e84039f8c84b7cc46501/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc13/external/fmt/10.2.1-36fc7f6c79f01f17e1a4b853aff183cd/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc13/external/md5/1.0.0-ea9ab1991fd07bc46b92ce4a79651057/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc13/external/tinyxml2/6.2.0-f3fb3ad5f8c256e1e42fc6264747acf5/include -O3 -pthread -pipe -Werror=main -Werror=pointer-arith -Werror=overlength-strings -Wno-vla -Werror=overflow -std=c++20 -ftree-vectorize -Werror=array-bounds -Werror=format-contains-nul -Werror=type-limits -fvisibility-inlines-hidden -fno-math-errno --param vect-max-version-for-alias-checks=50 -Xassembler --compress-debug-sections -fuse-ld=bfd -march=x86-64-v3 -felide-constructors -fmessage-length=0 -fimplicit-constexpr -Wall -Wno-non-template-friend -Wno-long-long -Wreturn-type -Wextra -Wpessimizing-move -Wclass-memaccess -Wno-cast-function-type -Wno-unused-but-set-parameter -Wno-ignored-qualifiers -Wno-unused-parameter -Wunused -Wparentheses -Werror=return-type -Werror=missing-braces -Werror=unused-value -Werror=unused-label -Werror=address -Werror=format -Werror=sign-compare -Werror=write-strings -Werror=delete-non-virtual-dtor -Werror=strict-aliasing -Werror=narrowing -Werror=unused-but-set-variable -Werror=reorder -Werror=unused-variable -Werror=conversion-null -Werror=return-local-addr -Wnon-virtual-dtor -Werror=switch -fdiagnostics-show-option -Wno-unused-local-typedefs -Wno-attributes -Wno-psabi -Wno-error=unused-variable -DBOOST_DISABLE_ASSERTS -flto=auto -fipa-icf -flto-odr-type-merging -fno-fat-lto-objects -Wodr -fPIC -MMD -MF tmp/el8_amd64_gcc13/src/CondCore/DBOutputService/src/CondCoreDBOutputService/PoolDBOutputService.cc.d src/CondCore/DBOutputService/src/PoolDBOutputService.cc -o tmp/el8_amd64_gcc13/src/CondCore/DBOutputService/src/CondCoreDBOutputService/PoolDBOutputService.cc.o
>> Building shared library tmp/el8_amd64_gcc13/src/CondCore/DBOutputService/src/CondCoreDBOutputService/libCondCoreDBOutputService.so
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc13/external/gcc/13.3.1-92b2d78dc343ed2bc93c8eb414ddc9ff/bin/c++ -O3 -pthread -pipe -Werror=main -Werror=pointer-arith -Werror=overlength-strings -Wno-vla -Werror=overflow -std=c++20 -ftree-vectorize -Werror=array-bounds -Werror=format-contains-nul -Werror=type-limits -fvisibility-inlines-hidden -fno-math-errno --param vect-max-version-for-alias-checks=50 -Xassembler --compress-debug-sections -fuse-ld=bfd -march=x86-64-v3 -felide-constructors -fmessage-length=0 -fimplicit-constexpr -Wall -Wno-non-template-friend -Wno-long-long -Wreturn-type -Wextra -Wpessimizing-move -Wclass-memaccess -Wno-cast-function-type -Wno-unused-but-set-parameter -Wno-ignored-qualifiers -Wno-unused-parameter -Wunused -Wparentheses -Werror=return-type -Werror=missing-braces -Werror=unused-value -Werror=unused-label -Werror=address -Werror=format -Werror=sign-compare -Werror=write-strings -Werror=delete-non-virtual-dtor -Werror=strict-aliasing -Werror=narrowing -Werror=unused-but-set-variable -Werror=reorder -Werror=unused-variable -Werror=conversion-null -Werror=return-local-addr -Wnon-virtual-dtor -Werror=switch -fdiagnostics-show-option -Wno-unused-local-typedefs -Wno-attributes -Wno-psabi -Wno-error=unused-variable -DBOOST_DISABLE_ASSERTS -flto=auto -fipa-icf -flto-odr-type-merging -fno-fat-lto-objects -Wodr -shared -Wl,-E    -Wl,-z,defs     tmp/el8_amd64_gcc13/src/CondCore/DBOutputService/src/CondCoreDBOutputService/OnlineDBOutputService.cc.o tmp/el8_amd64_gcc13/src/CondCore/DBOutputService/src/CondCoreDBOutputService/PoolDBOutputService.cc.o -o tmp/el8_amd64_gcc13/src/CondCore/DBOutputService/src/CondCoreDBOutputService/libCondCoreDBOutputService.so -Wl,-E -Wl,--hash-style=gnu -Wl,--as-needed -Wl,-z,noexecstack -L/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_15_0_X_2025-01-31-2300/biglib/el8_amd64_gcc13 -L/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_15_0_X_2025-01-31-2300/lib/el8_amd64_gcc13 -L/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_15_0_X_2025-01-31-2300/external/el8_amd64_gcc13/lib -L/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_15_0_X_2025-01-31-2300/static/el8_amd64_gcc13 -lCondCoreCondDB -lFWCoreFramework -lCondFormatsCommon -lFWCoreCommon -lFWCoreServiceRegistry -lDataFormatsCommon -lFWCoreParameterSet -lFWCoreMessageLogger -lDataFormatsProvenance -lFWCoreConcurrency -lFWCorePluginManager -lFWCoreReflection -lCondFormatsSerialization -lFWCoreUtilities -lFWCoreVersion -lUtilitiesOpenSSL -llcg_CoralCommon -llcg_RelationalAccess -llcg_CoralKernel -llcg_CoralBase -lTree -lNet -lThread -lboost_filesystem -lMathCore -lRIO -lboost_program_options -lboost_serialization -lboost_system -lCore -lboost_thread -lboost_date_time -lpcre -lbz2 -lcurl -luuid -ltbb -lxerces-c -llzma -lz -lfmt -lcms-md5 -lssl -lcrypto -lcrypt -ldl -lrt -lstdc++fs -ltinyxml2
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc13/external/gcc/13.3.1-92b2d78dc343ed2bc93c8eb414ddc9ff/bin/../lib/gcc/x86_64-redhat-linux-gnu/13.3.1/../../../../x86_64-redhat-linux-gnu/bin/ld.bfd: cannot find -lCondCoreCondDB: No such file or directory
collect2: error: ld returned 1 exit status
gmake: *** [tmp/el8_amd64_gcc13/src/CondCore/DBOutputService/src/CondCoreDBOutputService/libCondCoreDBOutputService.so] Error 1
Leaving library rule at CondCore/DBOutputService
Entering library rule at src/CondCore/DBOutputService/plugins
>> Compiling edm plugin src/CondCore/DBOutputService/plugins/SealModule.cc
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc13/external/gcc/13.3.1-92b2d78dc343ed2bc93c8eb414ddc9ff/bin/c++ -c -DCMS_MICRO_ARCH='x86-64-v3' -DGNU_GCC -D_GNU_SOURCE -DTBB_USE_GLIBCXX_VERSION=130301 -DTBB_SUPPRESS_DEPRECATED_MESSAGES -DTBB_PREVIEW_RESUMABLE_TASKS=1 -DTBB_PREVIEW_TASK_GROUP_EXTENSIONS=1 -DBOOST_SPIRIT_THREADSAFE -DPHOENIX_THREADSAFE -DBOOST_MATH_DISABLE_STD_FPCLASSIFY -DBOOST_UUID_RANDOM_PROVIDER_FORCE_POSIX -DCMSSW_GIT_HASH='CMSSW_15_0_X_2025-01-31-2300' -DPROJECT_NAME='CMSSW' -DPROJECT_VERSION='CMSSW_15_0_X_2025-01-31-2300' -Isrc -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc13/cms/coral/CORAL_2_3_21-efc1cdaf72cff32c6c1b98f0a233205b/include/LCG -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc13/external/pcre/8.43-98b91818238e6315baa782c93d2e1a8d/include -isystem/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc13/external/boost/1.80.0-219130170382a74ab026bc7e8f3aed50/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc13/external/bz2lib/1.0.6-f92c52f66bf6507988f946bd77fb689c/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc13/external/curl/7.79.0-a23d7bdb483609b91c18e4d97a98c4b0/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc13/external/libuuid/2.34-c2b49c79f52c48d7cb42b214bd8f95f6/include -isystem/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc13/lcg/root/6.32.09-673228292062580b5c2725e1de3085a5/include -isystem/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc13/external/tbb/v2021.9.0-fc977fda7ed4cc29c17d19c6703a0199/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc13/external/xerces-c/3.1.3-14d6230deabf01bcafd3d32c7a59dc27/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc13/external/xz/5.2.5-5f1d064218d21615d94b64b937b2e0b3/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc13/external/zlib/1.2.13-31c9b620a337e84039f8c84b7cc46501/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc13/external/fmt/10.2.1-36fc7f6c79f01f17e1a4b853aff183cd/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc13/external/md5/1.0.0-ea9ab1991fd07bc46b92ce4a79651057/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc13/external/tinyxml2/6.2.0-f3fb3ad5f8c256e1e42fc6264747acf5/include -O3 -pthread -pipe -Werror=main -Werror=pointer-arith -Werror=overlength-strings -Wno-vla -Werror=overflow -std=c++20 -ftree-vectorize -Werror=array-bounds -Werror=format-contains-nul -Werror=type-limits -fvisibility-inlines-hidden -fno-math-errno --param vect-max-version-for-alias-checks=50 -Xassembler --compress-debug-sections -fuse-ld=bfd -march=x86-64-v3 -felide-constructors -fmessage-length=0 -fimplicit-constexpr -Wall -Wno-non-template-friend -Wno-long-long -Wreturn-type -Wextra -Wpessimizing-move -Wclass-memaccess -Wno-cast-function-type -Wno-unused-but-set-parameter -Wno-ignored-qualifiers -Wno-unused-parameter -Wunused -Wparentheses -Werror=return-type -Werror=missing-braces -Werror=unused-value -Werror=unused-label -Werror=address -Werror=format -Werror=sign-compare -Werror=write-strings -Werror=delete-non-virtual-dtor -Werror=strict-aliasing -Werror=narrowing -Werror=unused-but-set-variable -Werror=reorder -Werror=unused-variable -Werror=conversion-null -Werror=return-local-addr -Wnon-virtual-dtor -Werror=switch -fdiagnostics-show-option -Wno-unused-local-typedefs -Wno-attributes -Wno-psabi -Wno-error=unused-variable -DBOOST_DISABLE_ASSERTS -flto=auto -fipa-icf -flto-odr-type-merging -fno-fat-lto-objects -Wodr -fPIC -MMD -MF tmp/el8_amd64_gcc13/src/CondCore/DBOutputService/plugins/CondCoreDBOutputServicePlugins/SealModule.cc.d src/CondCore/DBOutputService/plugins/SealModule.cc -o tmp/el8_amd64_gcc13/src/CondCore/DBOutputService/plugins/CondCoreDBOutputServicePlugins/SealModule.cc.o

@fwyzard
Copy link
Contributor Author

fwyzard commented Feb 2, 2025

please test with cms-sw/cmssw#47241 for el8_amd64_gcc13

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 3, 2025

-1

Failed Tests: HeaderConsistency UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7813ab/44138/summary.html
COMMIT: fdb49d5
CMSSW: CMSSW_15_0_X_2025-01-31-2300/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/9667/44138/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7813ab/44138/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7813ab/44138/git-merge-result

Unit Tests

I found 5 errors in the following unit tests:

---> test test-particleLevel_fromHepMC3 had ERRORS
---> test test-rivet-run had ERRORS
---> test test-yoda-merge had ERRORS
and more ...

Comparison Summary

Summary:

  • You potentially removed 59 lines from the logs
  • Reco comparison results: 76723 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 4016938
  • DQMHistoTests: Total failures: 478332
  • DQMHistoTests: Total nulls: 311
  • DQMHistoTests: Total successes: 3538275
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 4.671 KiB( 49 files compared)
  • DQMHistoSizes: changed ( 10224.0 ): -0.352 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 13034.0 ): -0.104 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 145.604 ): 0.051 KiB JetMET/SUSYDQM
  • DQMHistoSizes: changed ( 17034.0 ): 0.352 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 250202.181 ): -0.176 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 25202.0 ): -0.098 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 7.3 ): 6.046 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 8.0 ): -1.048 KiB SiStrip/MechanicalView
  • Checked 218 log files, 189 edm output root files, 50 DQM output files
  • TriggerResults: found differences in 16 / 48 workflows

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
externals-pending orp-pending pending-signatures requires-external tests-rejected
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fwyzard @cmsbuild @smuzaffar