Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GCC14] Apply fix for https://gcc.gnu.org/bugzilla/show_bug.cgi?id=118817 #9686

Merged
merged 5 commits into from
Feb 14, 2025

Conversation

smuzaffar
Copy link
Contributor

No description provided.

@smuzaffar
Copy link
Contributor Author

test parameters:

  • full_cmssw = true

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @smuzaffar for branch IB/CMSSW_15_1_X/g14.

@cmsbuild, @iarspider, @smuzaffar can you please review it and eventually sign? Thanks.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.
cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 11, 2025

cms-bot internal usage

@smuzaffar
Copy link
Contributor Author

please test for el8_amd64_gcc14

@smuzaffar smuzaffar changed the title Apply fix for https://gcc.gnu.org/bugzilla/show_bug.cgi?id=118817 [GCC14] Apply fix for https://gcc.gnu.org/bugzilla/show_bug.cgi?id=118817 Feb 11, 2025
@cmsbuild
Copy link
Contributor

-1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-da4e10/44320/summary.html
COMMIT: c0db886
CMSSW: CMSSW_15_1_X_2025-02-10-2300/el8_amd64_gcc14
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/9686/44320/install.sh to create a dev area with all the needed externals and cmssw changes.

External Build

I found compilation error when building:

Trying to install the rpm package external+gcc+14.2.1-985fcc6d74651f5a6787c9707e140c11 just built.
Checking package dependencies: external+gcc+14.2.1-985fcc6d74651f5a6787c9707e140c11
Done checking package dependencies: external+gcc+14.2.1-985fcc6d74651f5a6787c9707e140c11
Checking local path dependency for rpm package external+gcc+14.2.1-985fcc6d74651f5a6787c9707e140c11 just build.
RPM installation stderr gcc:
error: Failed dependencies:
	perl(bigint) is needed by external+gcc+14.2.1-985fcc6d74651f5a6787c9707e140c11-1-1.x86_64

Failed to install RPM for gcc
Requested to quit.
Requested to quit.


@cmsbuild
Copy link
Contributor

Pull request #9686 was updated.

@smuzaffar
Copy link
Contributor Author

please test for el8_amd64_gcc14

@cmsbuild
Copy link
Contributor

-1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-da4e10/44333/summary.html
COMMIT: c1c225a
CMSSW: CMSSW_15_1_X_2025-02-10-2300/el8_amd64_gcc14
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/9686/44333/install.sh to create a dev area with all the needed externals and cmssw changes.

External Build

I found compilation warning when building: See details on the summary page.

@smuzaffar
Copy link
Contributor Author

please test for el8_amd64_gcc14

@cmsbuild
Copy link
Contributor

-1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-da4e10/44342/summary.html
COMMIT: c1c225a
CMSSW: CMSSW_15_1_X_2025-02-10-2300/el8_amd64_gcc14
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/9686/44342/install.sh to create a dev area with all the needed externals and cmssw changes.

External Build

I found compilation error when building:

Requested to quit.
Requested to quit.
* The action "build-external+tensorflow-sources_x86-64-v2+2.12.0-de50965a97d8c2924c7a047399a94df0" was not completed successfully because Failed to build tensorflow-sources_x86-64-v2. Log file in /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc14/external/tensorflow-sources_x86-64-v2/2.12.0-de50965a97d8c2924c7a047399a94df0/log. Final lines of the log file:
In file included from external/XNNPACK/src/amalgam/sse.c:12:
external/XNNPACK/src/xnnpack/conv.h: In function 'xnn_f32_conv_hwc2chw_ukernel_3x3s2p1c3x4__sse_2x2':
external/XNNPACK/src/xnnpack/conv.h:79:1: internal compiler error: in find_or_generate_expression, at tree-ssa-pre.cc:2747
79 | DECLARE_F32_CONV_HWC2CHW_UKERNEL_FUNCTION(xnn_f32_conv_hwc2chw_ukernel_3x3s2p1c3x4__sse_2x2)
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Please submit a full bug report, with preprocessed source (by using -freport-bug).
See  for instructions.
[597 / 650] checking cached actions


@cmsbuild
Copy link
Contributor

Pull request #9686 was updated.

@cmsbuild
Copy link
Contributor

-1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-da4e10/44356/summary.html
COMMIT: 9b7bd13
CMSSW: CMSSW_15_1_X_2025-02-10-2300/el8_amd64_gcc14
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/9686/44356/install.sh to create a dev area with all the needed externals and cmssw changes.

External Build

I found compilation error when building:

make[2]: *** [Makefile:5055: all-stage1-gcc] Error 2
make[2]: Leaving directory '/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc14/external/gcc/14.2.1-21e0b402d644a7adbf5d5237a3e1e047/gcc-14.2.1/obj'
make[1]: *** [Makefile:26019: stage1-bubble] Error 2
make[1]: Leaving directory '/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc14/external/gcc/14.2.1-21e0b402d644a7adbf5d5237a3e1e047/gcc-14.2.1/obj'
make: *** [Makefile:26958: profiledbootstrap] Error 2
error: Bad exit status from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/rpm-tmp.BFsL8k (%build)

RPM build warnings:
line 35: It's not recommended to have unversioned Obsoletes: Obsoletes: external+gcc+14.2.1-21e0b402d644a7adbf5d5237a3e1e047
Macro expanded in comment on line 382: %{pkginstroot}/lib64



@smuzaffar
Copy link
Contributor Author

please test for el8_amd64_gcc14

@cmsbuild
Copy link
Contributor

Pull request #9686 was updated.

@cmsbuild
Copy link
Contributor

-1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-da4e10/44367/summary.html
COMMIT: c03a37d
CMSSW: CMSSW_15_1_X_2025-02-10-2300/el8_amd64_gcc14
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/9686/44367/install.sh to create a dev area with all the needed externals and cmssw changes.

External Build

I found compilation error when building:

Trying to install the rpm package external+gcc+14.2.1-a4c2244bdd26fb9bfca8cf8ad8db553a just built.
Checking package dependencies: external+gcc+14.2.1-a4c2244bdd26fb9bfca8cf8ad8db553a
Done checking package dependencies: external+gcc+14.2.1-a4c2244bdd26fb9bfca8cf8ad8db553a
Checking local path dependency for rpm package external+gcc+14.2.1-a4c2244bdd26fb9bfca8cf8ad8db553a just build.
RPM installation stderr gcc:
error: Failed dependencies:
	perl(bigint) is needed by external+gcc+14.2.1-a4c2244bdd26fb9bfca8cf8ad8db553a-1-1.x86_64

Failed to install RPM for gcc
Starting to process package external+autotools+1.5-de955f770934dc743c02ad3a7295d8d9
Checking if autotools is cached.


@cmsbuild
Copy link
Contributor

-1

Failed Tests: Build
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-da4e10/44368/summary.html
COMMIT: c03a37d
CMSSW: CMSSW_15_1_X_2025-02-10-2300/el8_amd64_gcc14
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/9686/44368/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-da4e10/44368/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-da4e10/44368/git-merge-result

Build

I found compilation error when building:

/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc14/external/gcc/14.2.1-a4c2244bdd26fb9bfca8cf8ad8db553a/bin/c++ -c -DCMS_MICRO_ARCH='' -DGNU_GCC -D_GNU_SOURCE -DTBB_USE_GLIBCXX_VERSION=140201 -DTBB_SUPPRESS_DEPRECATED_MESSAGES -DTBB_PREVIEW_RESUMABLE_TASKS=1 -DTBB_PREVIEW_TASK_GROUP_EXTENSIONS=1 -DCMSSW_GIT_HASH='CMSSW_15_1_X_2025-02-10-2300' -DPROJECT_NAME='CMSSW' -DPROJECT_VERSION='CMSSW_15_1_X_2025-02-10-2300' -Isrc -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc14/external/pcre/8.43-b3d7ddac9db1bc93b05b75ba12675d43/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc14/external/bz2lib/1.0.6-deabcd0fc65a645f60c3d5cb78ec54ee/include -isystem/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc14/lcg/root/6.32.09-0df80212ed4ac79bed6b22e29b5ff359/include -isystem/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc14/external/tbb/v2021.9.0-f433ed4202726c60517b1106e693b9cc/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc14/cms/vdt/0.4.3-39263f445b5f3cfdd557f3fb345582be/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc14/external/xz/5.6.4-3d920594ff0d3532c1d7a2ce124f1587/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc14/external/zlib/1.2.13-96b89a1c43115e0db95baed61278390c/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc14/external/json/3.11.3-cbbb80699f3df51b73f4142166858b5e/include -O3 -pthread -pipe -Werror=main -Werror=pointer-arith -Werror=overlength-strings -Wno-vla -Werror=overflow -std=c++20 -ftree-vectorize -Werror=array-bounds -Werror=format-contains-nul -Werror=type-limits -fvisibility-inlines-hidden -fno-math-errno --param vect-max-version-for-alias-checks=50 -Xassembler --compress-debug-sections -fuse-ld=bfd -march=x86-64-v3 -felide-constructors -fmessage-length=0 -Wall -Wno-non-template-friend -Wno-long-long -Wreturn-type -Wextra -Wpessimizing-move -Wclass-memaccess -Wno-cast-function-type -Wno-unused-but-set-parameter -Wno-ignored-qualifiers -Wno-unused-parameter -Wunused -Wparentheses -Werror=return-type -Werror=missing-braces -Werror=unused-value -Werror=unused-label -Werror=address -Werror=format -Werror=sign-compare -Werror=write-strings -Werror=delete-non-virtual-dtor -Werror=strict-aliasing -Werror=narrowing -Werror=unused-but-set-variable -Werror=reorder -Werror=unused-variable -Werror=conversion-null -Werror=return-local-addr -Wnon-virtual-dtor -Werror=switch -fdiagnostics-show-option -Wno-unused-local-typedefs -Wno-attributes -Wno-psabi -fno-reciprocal-math -mrecip=none -DBOOST_DISABLE_ASSERTS -fopenmp-simd -flto=auto -fipa-icf -flto-odr-type-merging -fno-fat-lto-objects -Wodr -fPIC -MMD -MF tmp/el8_amd64_gcc14/src/RecoTracker/MkFitCore/src/RecoTrackerMkFitCore/radix_sort.cc.d src/RecoTracker/MkFitCore/src/radix_sort.cc -o tmp/el8_amd64_gcc14/src/RecoTracker/MkFitCore/src/RecoTrackerMkFitCore/radix_sort.cc.o
>> Building shared library tmp/el8_amd64_gcc14/src/RecoTracker/MkFitCore/src/RecoTrackerMkFitCore/libRecoTrackerMkFitCore.so
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc14/external/gcc/14.2.1-a4c2244bdd26fb9bfca8cf8ad8db553a/bin/c++ -O3 -pthread -pipe -Werror=main -Werror=pointer-arith -Werror=overlength-strings -Wno-vla -Werror=overflow -std=c++20 -ftree-vectorize -Werror=array-bounds -Werror=format-contains-nul -Werror=type-limits -fvisibility-inlines-hidden -fno-math-errno --param vect-max-version-for-alias-checks=50 -Xassembler --compress-debug-sections -fuse-ld=bfd -march=x86-64-v3 -felide-constructors -fmessage-length=0 -Wall -Wno-non-template-friend -Wno-long-long -Wreturn-type -Wextra -Wpessimizing-move -Wclass-memaccess -Wno-cast-function-type -Wno-unused-but-set-parameter -Wno-ignored-qualifiers -Wno-unused-parameter -Wunused -Wparentheses -Werror=return-type -Werror=missing-braces -Werror=unused-value -Werror=unused-label -Werror=address -Werror=format -Werror=sign-compare -Werror=write-strings -Werror=delete-non-virtual-dtor -Werror=strict-aliasing -Werror=narrowing -Werror=unused-but-set-variable -Werror=reorder -Werror=unused-variable -Werror=conversion-null -Werror=return-local-addr -Wnon-virtual-dtor -Werror=switch -fdiagnostics-show-option -Wno-unused-local-typedefs -Wno-attributes -Wno-psabi -fno-reciprocal-math -mrecip=none -DBOOST_DISABLE_ASSERTS -fopenmp-simd -flto=auto -fipa-icf -flto-odr-type-merging -fno-fat-lto-objects -Wodr -shared -Wl,-E    -Wl,-z,defs     tmp/el8_amd64_gcc14/src/RecoTracker/MkFitCore/src/RecoTrackerMkFitCore/CandCloner.cc.o tmp/el8_amd64_gcc14/src/RecoTracker/MkFitCore/src/RecoTrackerMkFitCore/Config.cc.o tmp/el8_amd64_gcc14/src/RecoTracker/MkFitCore/src/RecoTrackerMkFitCore/Debug.cc.o tmp/el8_amd64_gcc14/src/RecoTracker/MkFitCore/src/RecoTrackerMkFitCore/FindingFoos.cc.o tmp/el8_amd64_gcc14/src/RecoTracker/MkFitCore/src/RecoTrackerMkFitCore/Hit.cc.o tmp/el8_amd64_gcc14/src/RecoTracker/MkFitCore/src/RecoTrackerMkFitCore/HitStructures.cc.o tmp/el8_amd64_gcc14/src/RecoTracker/MkFitCore/src/RecoTrackerMkFitCore/IterationConfig.cc.o tmp/el8_amd64_gcc14/src/RecoTracker/MkFitCore/src/RecoTrackerMkFitCore/KalmanUtilsMPlex.cc.o tmp/el8_amd64_gcc14/src/RecoTracker/MkFitCore/src/RecoTrackerMkFitCore/Matriplex/MatriplexCommon.cc.o tmp/el8_amd64_gcc14/src/RecoTracker/MkFitCore/src/RecoTrackerMkFitCore/MiniPropagators.cc.o tmp/el8_amd64_gcc14/src/RecoTracker/MkFitCore/src/RecoTrackerMkFitCore/MkBuilder.cc.o tmp/el8_amd64_gcc14/src/RecoTracker/MkFitCore/src/RecoTrackerMkFitCore/MkBuilderWrapper.cc.o tmp/el8_amd64_gcc14/src/RecoTracker/MkFitCore/src/RecoTrackerMkFitCore/MkFinder.cc.o tmp/el8_amd64_gcc14/src/RecoTracker/MkFitCore/src/RecoTrackerMkFitCore/MkFitter.cc.o tmp/el8_amd64_gcc14/src/RecoTracker/MkFitCore/src/RecoTrackerMkFitCore/PropagationMPlex.cc.o tmp/el8_amd64_gcc14/src/RecoTracker/MkFitCore/src/RecoTrackerMkFitCore/PropagationMPlexCommon.cc.o tmp/el8_amd64_gcc14/src/RecoTracker/MkFitCore/src/RecoTrackerMkFitCore/PropagationMPlexEndcap.cc.o tmp/el8_amd64_gcc14/src/RecoTracker/MkFitCore/src/RecoTrackerMkFitCore/PropagationMPlexPlane.cc.o tmp/el8_amd64_gcc14/src/RecoTracker/MkFitCore/src/RecoTrackerMkFitCore/Track.cc.o tmp/el8_amd64_gcc14/src/RecoTracker/MkFitCore/src/RecoTrackerMkFitCore/TrackStructures.cc.o tmp/el8_amd64_gcc14/src/RecoTracker/MkFitCore/src/RecoTrackerMkFitCore/TrackerInfo.cc.o tmp/el8_amd64_gcc14/src/RecoTracker/MkFitCore/src/RecoTrackerMkFitCore/radix_sort.cc.o -o tmp/el8_amd64_gcc14/src/RecoTracker/MkFitCore/src/RecoTrackerMkFitCore/libRecoTrackerMkFitCore.so -Wl,-E -Wl,--hash-style=gnu -Wl,--as-needed -Wl,-z,noexecstack -L/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_15_1_X_2025-02-10-2300/biglib/el8_amd64_gcc14 -L/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_15_1_X_2025-02-10-2300/lib/el8_amd64_gcc14 -L/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_15_1_X_2025-02-10-2300/external/el8_amd64_gcc14/lib -L/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_15_1_X_2025-02-10-2300/static/el8_amd64_gcc14 -lSmatrix -lCore -lpcre -lbz2 -ltbb -llzma -lz -lcrypt -ldl -lrt
In function 'RotateResidualsOnPlane',
    inlined from 'kalmanOperationPlane' at src/RecoTracker/MkFitCore/src/KalmanUtilsMPlex.cc:2031:27:
src/RecoTracker/MkFitCore/src/KalmanUtilsMPlex.cc:413:31: error: array subscript 'const struct Matriplex[0]' is partly outside array bounds of 'struct MPlex2H[1]' [-Werror=array-bounds=]
  413 |       B(n, 0, 0) = R(n, 0, 0) * A(n, 0, 0) + R(n, 0, 1) * A(n, 1, 0) + R(n, 0, 2) * A(n, 2, 0);
      |                               ^
src/RecoTracker/MkFitCore/src/KalmanUtilsMPlex.cc: In function 'kalmanOperationPlane':
src/RecoTracker/MkFitCore/src/KalmanUtilsMPlex.cc:2014:13: note: object 'prj' of size 192
 2014 |     MPlex2H prj;


@cmsbuild
Copy link
Contributor

Pull request #9686 was updated.

@smuzaffar
Copy link
Contributor Author

please test for el8_amd64_gcc14

@smuzaffar
Copy link
Contributor Author

please test for el8_amd64_gcc14

@cmsbuild
Copy link
Contributor

-1

Failed Tests: Build
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-da4e10/44380/summary.html
COMMIT: 5520ae1
CMSSW: CMSSW_15_1_X_2025-02-10-2300/el8_amd64_gcc14
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/9686/44380/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-da4e10/44380/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-da4e10/44380/git-merge-result

Build

I found compilation error when building:

/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc14/external/gcc/14.2.1-475d4640d5186beb85fe6c9d366d668f/bin/c++ -c -DCMS_MICRO_ARCH='' -DGNU_GCC -D_GNU_SOURCE -DTBB_USE_GLIBCXX_VERSION=140201 -DTBB_SUPPRESS_DEPRECATED_MESSAGES -DTBB_PREVIEW_RESUMABLE_TASKS=1 -DTBB_PREVIEW_TASK_GROUP_EXTENSIONS=1 -DCMSSW_GIT_HASH='CMSSW_15_1_X_2025-02-10-2300' -DPROJECT_NAME='CMSSW' -DPROJECT_VERSION='CMSSW_15_1_X_2025-02-10-2300' -Isrc -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc14/external/pcre/8.43-fec6e6028744fb6ef466c775a44bdbc6/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc14/external/bz2lib/1.0.6-5144693e7a37ea5b81cd450abd20a4e3/include -isystem/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc14/lcg/root/6.32.09-a34837ee797fd9a1b11fdc748957c511/include -isystem/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc14/external/tbb/v2021.9.0-7a1f74aee3e72c1732e5fd4e8b0c92cd/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc14/cms/vdt/0.4.3-9a3e3f7b7c8090f8090c6d665bb4fb23/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc14/external/xz/5.6.4-293c8a36b5ace241306f493d5287e628/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc14/external/zlib/1.2.13-da03c076b1efafbcb159a35e20281b60/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc14/external/json/3.11.3-698e21cafcaabfe95a452a7b65ca4448/include -O3 -pthread -pipe -Werror=main -Werror=pointer-arith -Werror=overlength-strings -Wno-vla -Werror=overflow -std=c++20 -ftree-vectorize -Werror=array-bounds -Werror=format-contains-nul -Werror=type-limits -fvisibility-inlines-hidden -fno-math-errno --param vect-max-version-for-alias-checks=50 -Xassembler --compress-debug-sections -fuse-ld=bfd -march=x86-64-v3 -felide-constructors -fmessage-length=0 -Wall -Wno-non-template-friend -Wno-long-long -Wreturn-type -Wextra -Wpessimizing-move -Wclass-memaccess -Wno-cast-function-type -Wno-unused-but-set-parameter -Wno-ignored-qualifiers -Wno-unused-parameter -Wunused -Wparentheses -Werror=return-type -Werror=missing-braces -Werror=unused-value -Werror=unused-label -Werror=address -Werror=format -Werror=sign-compare -Werror=write-strings -Werror=delete-non-virtual-dtor -Werror=strict-aliasing -Werror=narrowing -Werror=unused-but-set-variable -Werror=reorder -Werror=unused-variable -Werror=conversion-null -Werror=return-local-addr -Wnon-virtual-dtor -Werror=switch -fdiagnostics-show-option -Wno-unused-local-typedefs -Wno-attributes -Wno-psabi -fno-reciprocal-math -mrecip=none -DBOOST_DISABLE_ASSERTS -fopenmp-simd -flto=auto -fipa-icf -flto-odr-type-merging -fno-fat-lto-objects -Wodr -fPIC -MMD -MF tmp/el8_amd64_gcc14/src/RecoTracker/MkFitCore/src/RecoTrackerMkFitCore/radix_sort.cc.d src/RecoTracker/MkFitCore/src/radix_sort.cc -o tmp/el8_amd64_gcc14/src/RecoTracker/MkFitCore/src/RecoTrackerMkFitCore/radix_sort.cc.o
>> Building shared library tmp/el8_amd64_gcc14/src/RecoTracker/MkFitCore/src/RecoTrackerMkFitCore/libRecoTrackerMkFitCore.so
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc14/external/gcc/14.2.1-475d4640d5186beb85fe6c9d366d668f/bin/c++ -O3 -pthread -pipe -Werror=main -Werror=pointer-arith -Werror=overlength-strings -Wno-vla -Werror=overflow -std=c++20 -ftree-vectorize -Werror=array-bounds -Werror=format-contains-nul -Werror=type-limits -fvisibility-inlines-hidden -fno-math-errno --param vect-max-version-for-alias-checks=50 -Xassembler --compress-debug-sections -fuse-ld=bfd -march=x86-64-v3 -felide-constructors -fmessage-length=0 -Wall -Wno-non-template-friend -Wno-long-long -Wreturn-type -Wextra -Wpessimizing-move -Wclass-memaccess -Wno-cast-function-type -Wno-unused-but-set-parameter -Wno-ignored-qualifiers -Wno-unused-parameter -Wunused -Wparentheses -Werror=return-type -Werror=missing-braces -Werror=unused-value -Werror=unused-label -Werror=address -Werror=format -Werror=sign-compare -Werror=write-strings -Werror=delete-non-virtual-dtor -Werror=strict-aliasing -Werror=narrowing -Werror=unused-but-set-variable -Werror=reorder -Werror=unused-variable -Werror=conversion-null -Werror=return-local-addr -Wnon-virtual-dtor -Werror=switch -fdiagnostics-show-option -Wno-unused-local-typedefs -Wno-attributes -Wno-psabi -fno-reciprocal-math -mrecip=none -DBOOST_DISABLE_ASSERTS -fopenmp-simd -flto=auto -fipa-icf -flto-odr-type-merging -fno-fat-lto-objects -Wodr -shared -Wl,-E    -Wl,-z,defs     tmp/el8_amd64_gcc14/src/RecoTracker/MkFitCore/src/RecoTrackerMkFitCore/CandCloner.cc.o tmp/el8_amd64_gcc14/src/RecoTracker/MkFitCore/src/RecoTrackerMkFitCore/Config.cc.o tmp/el8_amd64_gcc14/src/RecoTracker/MkFitCore/src/RecoTrackerMkFitCore/Debug.cc.o tmp/el8_amd64_gcc14/src/RecoTracker/MkFitCore/src/RecoTrackerMkFitCore/FindingFoos.cc.o tmp/el8_amd64_gcc14/src/RecoTracker/MkFitCore/src/RecoTrackerMkFitCore/Hit.cc.o tmp/el8_amd64_gcc14/src/RecoTracker/MkFitCore/src/RecoTrackerMkFitCore/HitStructures.cc.o tmp/el8_amd64_gcc14/src/RecoTracker/MkFitCore/src/RecoTrackerMkFitCore/IterationConfig.cc.o tmp/el8_amd64_gcc14/src/RecoTracker/MkFitCore/src/RecoTrackerMkFitCore/KalmanUtilsMPlex.cc.o tmp/el8_amd64_gcc14/src/RecoTracker/MkFitCore/src/RecoTrackerMkFitCore/Matriplex/MatriplexCommon.cc.o tmp/el8_amd64_gcc14/src/RecoTracker/MkFitCore/src/RecoTrackerMkFitCore/MiniPropagators.cc.o tmp/el8_amd64_gcc14/src/RecoTracker/MkFitCore/src/RecoTrackerMkFitCore/MkBuilder.cc.o tmp/el8_amd64_gcc14/src/RecoTracker/MkFitCore/src/RecoTrackerMkFitCore/MkBuilderWrapper.cc.o tmp/el8_amd64_gcc14/src/RecoTracker/MkFitCore/src/RecoTrackerMkFitCore/MkFinder.cc.o tmp/el8_amd64_gcc14/src/RecoTracker/MkFitCore/src/RecoTrackerMkFitCore/MkFitter.cc.o tmp/el8_amd64_gcc14/src/RecoTracker/MkFitCore/src/RecoTrackerMkFitCore/PropagationMPlex.cc.o tmp/el8_amd64_gcc14/src/RecoTracker/MkFitCore/src/RecoTrackerMkFitCore/PropagationMPlexCommon.cc.o tmp/el8_amd64_gcc14/src/RecoTracker/MkFitCore/src/RecoTrackerMkFitCore/PropagationMPlexEndcap.cc.o tmp/el8_amd64_gcc14/src/RecoTracker/MkFitCore/src/RecoTrackerMkFitCore/PropagationMPlexPlane.cc.o tmp/el8_amd64_gcc14/src/RecoTracker/MkFitCore/src/RecoTrackerMkFitCore/Track.cc.o tmp/el8_amd64_gcc14/src/RecoTracker/MkFitCore/src/RecoTrackerMkFitCore/TrackStructures.cc.o tmp/el8_amd64_gcc14/src/RecoTracker/MkFitCore/src/RecoTrackerMkFitCore/TrackerInfo.cc.o tmp/el8_amd64_gcc14/src/RecoTracker/MkFitCore/src/RecoTrackerMkFitCore/radix_sort.cc.o -o tmp/el8_amd64_gcc14/src/RecoTracker/MkFitCore/src/RecoTrackerMkFitCore/libRecoTrackerMkFitCore.so -Wl,-E -Wl,--hash-style=gnu -Wl,--as-needed -Wl,-z,noexecstack -L/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_15_1_X_2025-02-10-2300/biglib/el8_amd64_gcc14 -L/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_15_1_X_2025-02-10-2300/lib/el8_amd64_gcc14 -L/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_15_1_X_2025-02-10-2300/external/el8_amd64_gcc14/lib -L/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_15_1_X_2025-02-10-2300/static/el8_amd64_gcc14 -lSmatrix -lCore -lpcre -lbz2 -ltbb -llzma -lz -lcrypt -ldl -lrt
In function 'RotateResidualsOnPlane',
    inlined from 'kalmanOperationPlane' at src/RecoTracker/MkFitCore/src/KalmanUtilsMPlex.cc:2031:27:
src/RecoTracker/MkFitCore/src/KalmanUtilsMPlex.cc:413:31: error: array subscript 'const struct Matriplex[0]' is partly outside array bounds of 'struct MPlex2H[1]' [-Werror=array-bounds=]
  413 |       B(n, 0, 0) = R(n, 0, 0) * A(n, 0, 0) + R(n, 0, 1) * A(n, 1, 0) + R(n, 0, 2) * A(n, 2, 0);
      |                               ^
src/RecoTracker/MkFitCore/src/KalmanUtilsMPlex.cc: In function 'kalmanOperationPlane':
src/RecoTracker/MkFitCore/src/KalmanUtilsMPlex.cc:2014:13: note: object 'prj' of size 192
 2014 |     MPlex2H prj;


@smuzaffar
Copy link
Contributor Author

this seems to fix many of false-positive array-bound errors. Lets get this in IB and look for remaining array-bound issues to see if those are real or false positive

@smuzaffar smuzaffar merged commit c2b6a42 into IB/CMSSW_15_1_X/g14 Feb 14, 2025
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants