-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SIM: adopt cmssw for future Geant4 #43048
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43048/37243
|
please test |
A new Pull Request was created by @civanch (Vladimir Ivantchenko) for master. It involves the following packages:
@civanch, @mdhildreth can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-aac51b/35251/summary.html Comparison SummarySummary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2) |
+1
|
PR description:
Two modification are added, which should not affect any existing WF, but are useful for interface with future developments.
Updated method of gdml geometry dump, which now includes full information on sensitive detectors. This is needed for Phase2 and GPU R&D
Change code of ExceptionHandler, which now do the same actions but do not rely on the list of Geant4 exception types.
this PR addressed issues in cmsdist cms-sw/cmsdist#8741 and cms-sw/cmsdist#8742
PR validation:
private
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for: NO