Disable ROOT automatic class parsing during finishSchedule() #46858

fwyzard · 2024-12-03T21:45:54Z

PR description:

Disable ROOT automatic class parsing during ScheduleItems::finishSchedule(), while checking for missing dictionaries.

Add a test to check that the framework handles correctly the case of edm::Wrapper<T> where:

T has a dictionary;
edm::Wrapper<T> does not have a dictionary;
the corresponding classes.h file includes CUDA headers.

PR validation:

Unit tests and HLT pass.

cmsbuild · 2024-12-03T21:46:17Z

cms-bot internal usage

fwyzard · 2024-12-03T21:46:19Z

please test

cmsbuild · 2024-12-03T21:48:44Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46858/42887

makortel · 2024-12-03T21:48:54Z

Could you add e.g. "... during ScheduleItems::finishSchedule()` to the PR title? (to make it clear it the automatic parsing is still generally enabled)

cmsbuild · 2024-12-03T21:49:13Z

A new Pull Request was created by @fwyzard for master.

It involves the following packages:

FWCore/Framework (core)

@Dr15Jones, @makortel, @smuzaffar can you please review it and eventually sign? Thanks.
@makortel, @missirol, @wddgit this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

makortel · 2024-12-03T21:50:59Z

@wddgit @Dr15Jones Can you think of any drawbacks? (this part of the code should be fully serial)

fwyzard · 2024-12-03T22:11:39Z

Could you add e.g. "... during ScheduleItems::finishSchedule()` to the PR title? (to make it clear it the automatic parsing is still generally enabled)

Done, with only only finishSchedule() to stay on one line.

wddgit · 2024-12-03T22:33:20Z

I cannot think of any problems this would cause. +1 from me.

cmsbuild · 2024-12-03T23:30:00Z

+1

Size: This PR adds an extra 40KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-58643b/43228/summary.html
COMMIT: 054f633
CMSSW: CMSSW_15_0_X_2024-12-03-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/46858/43228/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 2 differences found in the comparisons
DQMHistoTests: Total files compared: 46
DQMHistoTests: Total histograms compared: 3484682
DQMHistoTests: Total failures: 382
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3484280
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 45 files compared)
Checked 202 log files, 172 edm output root files, 46 DQM output files
TriggerResults: no differences found

Dr15Jones · 2024-12-04T20:12:31Z

I'm concerned about placing the guard at that point. This decouples the setting of the behavior far from where the behavior needs to be changed. My suggestion is to

Change ProductRegistry::setFrozen to have a 3rd argument bool disableRootAutoParsing which is defaulted to false.
In Schedule::finishSetup pass true as the new argument to ProductRegistry::setFrozen
Add the guard conditionally inside ProductRegistry::setFrozen at the appropriate place

fwyzard · 2024-12-10T13:30:38Z

Hi @Dr15Jones, sure, I can make the changes you suggest.

However, note that there is a single place in the code that calls

     void setFrozen(std::set<TypeID> const& productTypesConsumed,
                    std::set<TypeID> const& elementTypesConsumed,
                    std::string const& processName);

which is the one where I would add the call to edm::SetClassParsing guard(false).

All other code paths call

    void setFrozen(bool initializeLookupInfo = true);

Do you still prefer to add the extra flag, or should I make the change unconditionally ?

fwyzard · 2025-02-18T22:16:47Z

If I disable class parsing just around constructing the StreamSchedule

diff --git a/FWCore/Framework/src/Schedule.cc b/FWCore/Framework/src/Schedule.cc
index 8796f935138..4bede1c5cb6 100644
--- a/FWCore/Framework/src/Schedule.cc
+++ b/FWCore/Framework/src/Schedule.cc
@@ -527,6 +528,8 @@ namespace edm {
     assert(0 < prealloc.numberOfStreams());
     streamSchedules_.reserve(prealloc.numberOfStreams());
     for (unsigned int i = 0; i < prealloc.numberOfStreams(); ++i) {
+      // disable ROOT automatic class parsing while constructing the modules
+      edm::SetClassParsing guard(false);
       streamSchedules_.emplace_back(make_shared_noexcept_false<StreamSchedule>(resultsInserter(),
                                                                                pathStatusInserters_,
                                                                                endPathStatusInserters_,

I get the expected behaviour, that is, a nice error message about the missing dictionary instead of the ROOT message:

----- Begin Fatal Exception 18-Feb-2025 23:14:13 CET-----------------------
An exception of category 'DictionaryNotFound' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing module: class=edmtest::MissingDictionaryCUDAProducer label='producer'
   [2] Calling ProductRegistryHelper::addToRegistry, checking dictionaries for produced types
Exception Message:
No data dictionary found for the following classes:

  edm::Wrapper<edmtest::MissingDictionaryCUDAObject>

Most likely each dictionary was never generated, but it may
be that it was generated in the wrong package. Please add
(or move) the specification '<class name="whatever"/>' to
the appropriate classes_def.xml file along with any other
information needed there. For example, if this class has any
transient members, you need to specify them in classes_def.xml.
Also include the class header in classes.h

A type listed above might or might not be the same as a
type declared by a producer module with the function 'produces'.
Instead it might be the type of a data member, base class,
wrapped type, or other object needed by a produced type. Below
is some additional information which lists the types declared
to be produced by a producer module that are associated with
the types whose dictionaries were not found:

  edmtest::MissingDictionaryCUDAObject

----- End Fatal Exception -------------------------------------------------

Is that a good place for it, or would it cause problems with some other features that actually need the class parsing ?

Dr15Jones · 2025-02-18T22:19:34Z

I would think it would break any code using the cutParser or the like as they need the class parser to run in order to probe the interfaces of the classes.

fwyzard · 2025-02-18T22:36:58Z

How about disabling the class parsing only inside edm::ProducerBase::registerProducts() ?

fwyzard · 2025-02-18T22:41:58Z

Indeed, this seems to work as well:

diff --git a/FWCore/Framework/src/ProducerBase.cc b/FWCore/Framework/src/ProducerBase.cc
index 2b28284a83d..0efd433dc87 100644
--- a/FWCore/Framework/src/ProducerBase.cc
+++ b/FWCore/Framework/src/ProducerBase.cc
@@ -69,6 +69,9 @@ namespace edm {
     }
     TypeLabelList const& plist = typeLabelList();
 
+    // disable ROOT automatic class parsing while registering the products
+    edm::SetClassParsing guard(false);
+
     ProductRegistryHelper::addToRegistry(plist.begin(), plist.end(), md, *(iReg), this, isListener);
     if (registrationCallback()) {
       iReg->watchProductAdditions(CallbackWrapper(producer, registrationCallback(), iReg, md));

fwyzard · 2025-02-18T22:43:38Z

Maybe even better inside ProductRegistryHelper::addToRegistry() ?

fwyzard · 2025-02-18T22:46:41Z

Yes, that also works, and it seems as close to the point of failure as it makes sense to go:

diff --git a/FWCore/Framework/src/ProductRegistryHelper.cc b/FWCore/Framework/src/ProductRegistryHelper.cc
index 290cdccaac1..94df82ae265 100644
--- a/FWCore/Framework/src/ProductRegistryHelper.cc
+++ b/FWCore/Framework/src/ProductRegistryHelper.cc
@@ -41,6 +42,9 @@ namespace edm {
     std::vector<std::string> producedTypes;
     std::set<std::tuple<BranchType, std::type_index, std::string>> registeredProducts;
 
+    // disable ROOT automatic class parsing while registering the products
+    edm::SetClassParsing guard(false);
+
     for (TypeLabelList::const_iterator p = iBegin; p != iEnd; ++p) {
       if (p->transition_ == Transition::BeginRun && not iProd->hasAbilityToProduceInBeginRuns()) {
         throwProducesWithoutAbility("BeginRun", p->typeID_.userClassName());

fwyzard · 2025-02-19T06:59:56Z

See #47397 for an alternative approach.

…onaries

Add a test to check that the framework handles correctly the case of edm::Wrapper<T> where: - T has a dictionary - edm::Wrapper<T> does not have a dictionary - the corresponding classes.h file includes CUDA headers

fwyzard · 2025-02-19T07:53:04Z

Rebased, and addressed the comments about the new test.

cmsbuild · 2025-02-19T07:54:38Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46858/43781

There are other open Pull requests which might conflict with changes you have proposed:
- File HeterogeneousCore/CUDATest/interface/MissingDictionaryCUDAObject.h modified in PR(s): Disable ROOT automatic class parsing in ProductRegistryHelper::addToRegistry #47397
- File HeterogeneousCore/CUDATest/plugins/MissingDictionaryCUDAProducer.cc modified in PR(s): Disable ROOT automatic class parsing in ProductRegistryHelper::addToRegistry #47397
- File HeterogeneousCore/CUDATest/src/classes.h modified in PR(s): Disable ROOT automatic class parsing in ProductRegistryHelper::addToRegistry #47397
- File HeterogeneousCore/CUDATest/src/classes_def.xml modified in PR(s): Disable ROOT automatic class parsing in ProductRegistryHelper::addToRegistry #47397
- File HeterogeneousCore/CUDATest/test/BuildFile.xml modified in PR(s): Disable ROOT automatic class parsing in ProductRegistryHelper::addToRegistry #47397
- File HeterogeneousCore/CUDATest/test/testMissingDictionaryCUDA.sh modified in PR(s): Disable ROOT automatic class parsing in ProductRegistryHelper::addToRegistry #47397
- File HeterogeneousCore/CUDATest/test/testMissingDictionaryCUDA_cfg.py modified in PR(s): Disable ROOT automatic class parsing in ProductRegistryHelper::addToRegistry #47397

cmsbuild · 2025-02-19T07:55:04Z

Pull request #46858 was updated. @Dr15Jones, @cmsbuild, @fwyzard, @makortel, @smuzaffar can you please check and sign again.

fwyzard · 2025-02-19T09:22:05Z

After more digging I think I found what is the underlying issue: #47400 .

makortel · 2025-02-20T16:15:48Z

@cmsbuild, please test

makortel · 2025-02-20T16:24:12Z

#6  0x00007fffe9cb048a in TClingLookupHelper__AutoParse(char const*) () from /cvmfs/cms.cern.ch/el8_amd64_gcc12/cms/cmssw/CMSSW_15_0_0_pre3/external/el8_amd64_gcc12/lib/libCling.so
...
#25 0x00007ffff7c9d738 in edm::StreamSchedule::StreamSchedule(std::shared_ptr<edm::TriggerResultInserter>, std::vector<edm::propagate_const<std::shared_ptr<edm::PathStatusInserter> >, std::allocator<edm::propagate_const<std::shared_ptr<edm::PathStatusInserter> > > >&, std::vector<edm::propagate_const<std::shared_ptr<edm::EndPathStatusInserter> >, std::allocator<edm::propagate_const<std::shared_ptr<edm::EndPathStatusInserter> > > >&, std::shared_ptr<edm::ModuleRegistry>, edm::ParameterSet&, edm::service::TriggerNamesService const&, edm::PreallocationConfiguration const&, edm::SignallingProductRegistry&, edm::ExceptionToActionTable const&, std::shared_ptr<edm::ActivityRegistry>, std::shared_ptr<edm::ProcessConfiguration const>, edm::StreamID, edm::ProcessContext const*) ()
   from /data/user/fwyzard/disable_ROOT_automatic_class_parsing/CMSSW_15_0_0_pre3/lib/el8_amd64_gcc12/libFWCoreFramework.so

@fwyzard Would you still happen to have the stack trace available between frames 6 and 25?

cmsbuild · 2025-02-20T20:14:44Z

-1

Failed Tests: UnitTests
Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-58643b/44547/summary.html
COMMIT: 568c8b1
CMSSW: CMSSW_15_1_X_2025-02-20-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46858/44547/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found 1 errors in the following unit tests:

---> test testMissingDictionaryCUDA had ERRORS

Comparison Summary

Summary:

You potentially added 3 lines to the logs
Reco comparison results: 14 differences found in the comparisons
DQMHistoTests: Total files compared: 49
DQMHistoTests: Total histograms compared: 3920300
DQMHistoTests: Total failures: 9
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3920271
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
Checked 214 log files, 184 edm output root files, 49 DQM output files
TriggerResults: no differences found

fwyzard · 2025-02-21T06:48:14Z

Would you still happen to have the stack trace available between frames 6 and 25?

Here is the full stack trace from a fresh run:

Thread 1 "cmsRun" hit Catchpoint 1 (exception thrown), 0x00007ffff712c2f1 in __cxxabiv1::__cxa_throw (obj=0x7fffcc1b5780, tinfo=0x7ffff7ea9690 <typeinfo for edm::Exception>, dest=0x7ffff7e6f4a0 <edm::Exception::~Exception()>) at ../../../../libstdc++-v3/libsupc++/eh_throw.cc:81
81      ../../../../libstdc++-v3/libsupc++/eh_throw.cc: No such file or directory.
#0  0x00007ffff712c2f1 in __cxxabiv1::__cxa_throw (obj=0x7fffcc1b5780, tinfo=0x7ffff7ea9690 <typeinfo for edm::Exception>, dest=0x7ffff7e6f4a0 <edm::Exception::~Exception()>) at ../../../../libstdc++-v3/libsupc++/eh_throw.cc:81
#1  0x00007ffff1c63b39 in (anonymous namespace)::RootErrorHandlerImpl(int, char const*, char const*) [clone .cold] () from /cvmfs/cms.cern.ch/el8_amd64_gcc12/cms/cmssw/CMSSW_15_0_0_pre3/lib/el8_amd64_gcc12/pluginFWCoreServicesPlugins.so
#2  0x00007ffff784e374 in ErrorHandler () from /cvmfs/cms.cern.ch/el8_amd64_gcc12/cms/cmssw/CMSSW_15_0_0_pre3/external/el8_amd64_gcc12/lib/libCore.so
#3  0x00007ffff779b5e4 in TObject::Error(char const*, char const*, ...) const () from /cvmfs/cms.cern.ch/el8_amd64_gcc12/cms/cmssw/CMSSW_15_0_0_pre3/external/el8_amd64_gcc12/lib/libCore.so
#4  0x00007fffe9c9405c in TCling::AutoParseImplRecurse(char const*, bool) () from /cvmfs/cms.cern.ch/el8_amd64_gcc12/cms/cmssw/CMSSW_15_0_0_pre3/external/el8_amd64_gcc12/lib/libCling.so
#5  0x00007fffe9c9e8ec in TCling::AutoParse(char const*) () from /cvmfs/cms.cern.ch/el8_amd64_gcc12/cms/cmssw/CMSSW_15_0_0_pre3/external/el8_amd64_gcc12/lib/libCling.so
#6  0x00007fffe9c7148a in TClingLookupHelper__AutoParse(char const*) () from /cvmfs/cms.cern.ch/el8_amd64_gcc12/cms/cmssw/CMSSW_15_0_0_pre3/external/el8_amd64_gcc12/lib/libCling.so
#7  0x00007fffe9bcae37 in ROOT::TMetaUtils::TClingLookupHelper::GetPartiallyDesugaredNameWithScopeHandling(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >&, bool) () from /cvmfs/cms.cern.ch/el8_amd64_gcc12/cms/cmssw/CMSSW_15_0_0_pre3/external/el8_amd64_gcc12/lib/libCling.so
#8  0x00007ffff7849fed in TClassEdit::GetNormalizedName(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >&, std::basic_string_view<char, std::char_traits<char> >) () from /cvmfs/cms.cern.ch/el8_amd64_gcc12/cms/cmssw/CMSSW_15_0_0_pre3/external/el8_amd64_gcc12/lib/libCore.so
#9  0x00007ffff7868160 in TClass::GetClass(char const*, bool, bool, unsigned long, unsigned long) () from /cvmfs/cms.cern.ch/el8_amd64_gcc12/cms/cmssw/CMSSW_15_0_0_pre3/external/el8_amd64_gcc12/lib/libCore.so
#10 0x00007ffff6b29101 in edm::TypeWithDict::byName(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, long) () from /cvmfs/cms.cern.ch/el8_amd64_gcc12/cms/cmssw/CMSSW_15_0_0_pre3/lib/el8_amd64_gcc12/libFWCoreReflection.so
#11 0x00007ffff6b2991f in edm::TypeWithDict::byName(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&) () from /cvmfs/cms.cern.ch/el8_amd64_gcc12/cms/cmssw/CMSSW_15_0_0_pre3/lib/el8_amd64_gcc12/libFWCoreReflection.so
#12 0x00007ffff6b7a2d0 in edm::BranchDescription::initFromDictionary() () from /cvmfs/cms.cern.ch/el8_amd64_gcc12/cms/cmssw/CMSSW_15_0_0_pre3/lib/el8_amd64_gcc12/libDataFormatsProvenance.so
#13 0x00007ffff6b7a5a3 in edm::BranchDescription::BranchDescription(edm::BranchType const&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, edm::TypeWithDict const&, bool, bool, std::set<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::less<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > >, std::allocator<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > > > const&) () from /cvmfs/cms.cern.ch/el8_amd64_gcc12/cms/cmssw/CMSSW_15_0_0_pre3/lib/el8_amd64_gcc12/libDataFormatsProvenance.so
#14 0x00007ffff7c5caae in edm::ProductRegistryHelper::addToRegistry(__gnu_cxx::__normal_iterator<edm::ProductRegistryHelper::TypeLabelItem const*, std::vector<edm::ProductRegistryHelper::TypeLabelItem, std::allocator<edm::ProductRegistryHelper::TypeLabelItem> > > const&, __gnu_cxx::__normal_iterator<edm::ProductRegistryHelper::TypeLabelItem const*, std::vector<edm::ProductRegistryHelper::TypeLabelItem, std::allocator<edm::ProductRegistryHelper::TypeLabelItem> > > const&, edm::ModuleDescription const&, edm::ProductRegistry&, edm::ProductRegistryHelper*, bool) () from /data/user/fwyzard/disable_ROOT_automatic_class_parsing/CMSSW_15_0_0_pre3/lib/el8_amd64_gcc12/libFWCoreFramework.so
#15 0x00007ffff7c5fafe in edm::ProducerBase::registerProducts(edm::ProducerBase*, edm::SignallingProductRegistry*, edm::ModuleDescription const&) () from /data/user/fwyzard/disable_ROOT_automatic_class_parsing/CMSSW_15_0_0_pre3/lib/el8_amd64_gcc12/libFWCoreFramework.so
#16 0x00007fffcea68cb8 in edm::maker::ModuleHolderT<edm::global::EDProducerBase>::registerProductsAndCallbacks(edm::SignallingProductRegistry*) () from /data/user/fwyzard/disable_ROOT_automatic_class_parsing/CMSSW_15_0_0_pre3/lib/el8_amd64_gcc12/pluginHeterogeneousCoreCUDATestPlugins.so
#17 0x00007ffff7cc0624 in edm::Maker::makeModule(edm::MakeModuleParams const&, edm::signalslot::Signal<void (edm::ModuleDescription const&)>&, edm::signalslot::Signal<void (edm::ModuleDescription const&)>&) const () from /data/user/fwyzard/disable_ROOT_automatic_class_parsing/CMSSW_15_0_0_pre3/lib/el8_amd64_gcc12/libFWCoreFramework.so
#18 0x00007ffff7c2a7d8 in edm::Factory::makeModule(edm::MakeModuleParams const&, edm::ModuleTypeResolverMaker const*, edm::signalslot::Signal<void (edm::ModuleDescription const&)>&, edm::signalslot::Signal<void (edm::ModuleDescription const&)>&) const () from /data/user/fwyzard/disable_ROOT_automatic_class_parsing/CMSSW_15_0_0_pre3/lib/el8_amd64_gcc12/libFWCoreFramework.so
#19 0x00007ffff7c3b23f in edm::ModuleRegistry::getModule(edm::MakeModuleParams const&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, edm::signalslot::Signal<void (edm::ModuleDescription const&)>&, edm::signalslot::Signal<void (edm::ModuleDescription const&)>&) () from /data/user/fwyzard/disable_ROOT_automatic_class_parsing/CMSSW_15_0_0_pre3/lib/el8_amd64_gcc12/libFWCoreFramework.so
#20 0x00007ffff7cc0dca in edm::WorkerRegistry::getWorker(edm::WorkerParams const&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&) () from /data/user/fwyzard/disable_ROOT_automatic_class_parsing/CMSSW_15_0_0_pre3/lib/el8_amd64_gcc12/libFWCoreFramework.so
#21 0x00007ffff7cc10a5 in edm::WorkerManager::getWorker(edm::ParameterSet&, edm::SignallingProductRegistry&, edm::PreallocationConfiguration const*, std::shared_ptr<edm::ProcessConfiguration const>, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&) () from /data/user/fwyzard/disable_ROOT_automatic_class_parsing/CMSSW_15_0_0_pre3/lib/el8_amd64_gcc12/libFWCoreFramework.so
#22 0x00007ffff7c9a5f0 in edm::(anonymous namespace)::getWorker(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, edm::ParameterSet&, edm::WorkerManager&, edm::SignallingProductRegistry&, edm::PreallocationConfiguration const*, std::shared_ptr<edm::ProcessConfiguration const>) () from /data/user/fwyzard/disable_ROOT_automatic_class_parsing/CMSSW_15_0_0_pre3/lib/el8_amd64_gcc12/libFWCoreFramework.so
#23 0x00007ffff7ca313f in edm::StreamSchedule::fillWorkers(edm::ParameterSet&, edm::SignallingProductRegistry&, edm::PreallocationConfiguration const*, std::shared_ptr<edm::ProcessConfiguration const>, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, bool, std::vector<edm::WorkerInPath, std::allocator<edm::WorkerInPath> >&, std::vector<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::allocator<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > > > const&, edm::ConditionalTaskHelper const&, std::unordered_set<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::hash<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > >, std::equal_to<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > >, std::allocator<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > > >&) () from /data/user/fwyzard/disable_ROOT_automatic_class_parsing/CMSSW_15_0_0_pre3/lib/el8_amd64_gcc12/libFWCoreFramework.so
#24 0x00007ffff7ca9c3f in edm::StreamSchedule::fillTrigPath(edm::ParameterSet&, edm::SignallingProductRegistry&, edm::PreallocationConfiguration const*, std::shared_ptr<edm::ProcessConfiguration const>, int, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, std::shared_ptr<edm::HLTGlobalStatus>, std::vector<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::allocator<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > > > const&, edm::ConditionalTaskHelper const&, std::unordered_set<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::hash<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > >, std::equal_to<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > >, std::allocator<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > > >&) () from /data/user/fwyzard/disable_ROOT_automatic_class_parsing/CMSSW_15_0_0_pre3/lib/el8_amd64_gcc12/libFWCoreFramework.so
#25 0x00007ffff7c9e578 in edm::StreamSchedule::StreamSchedule(std::shared_ptr<edm::TriggerResultInserter>, std::vector<edm::propagate_const<std::shared_ptr<edm::PathStatusInserter> >, std::allocator<edm::propagate_const<std::shared_ptr<edm::PathStatusInserter> > > >&, std::vector<edm::propagate_const<std::shared_ptr<edm::EndPathStatusInserter> >, std::allocator<edm::propagate_const<std::shared_ptr<edm::EndPathStatusInserter> > > >&, std::shared_ptr<edm::ModuleRegistry>, edm::ParameterSet&, edm::service::TriggerNamesService const&, edm::PreallocationConfiguration const&, edm::SignallingProductRegistry&, edm::ExceptionToActionTable const&, std::shared_ptr<edm::ActivityRegistry>, std::shared_ptr<edm::ProcessConfiguration const>, edm::StreamID, edm::ProcessContext const*) () from /data/user/fwyzard/disable_ROOT_automatic_class_parsing/CMSSW_15_0_0_pre3/lib/el8_amd64_gcc12/libFWCoreFramework.so
#26 0x00007ffff7c835da in edm::Schedule::Schedule(edm::ParameterSet&, edm::service::TriggerNamesService const&, edm::SignallingProductRegistry&, edm::ExceptionToActionTable const&, std::shared_ptr<edm::ActivityRegistry>, std::shared_ptr<edm::ProcessConfiguration const>, edm::PreallocationConfiguration const&, edm::ProcessContext const*, edm::ModuleTypeResolverMaker const*) () from /data/user/fwyzard/disable_ROOT_automatic_class_parsing/CMSSW_15_0_0_pre3/lib/el8_amd64_gcc12/libFWCoreFramework.so
#27 0x00007ffff7c97991 in edm::ScheduleItems::initModules(edm::ParameterSet&, edm::service::TriggerNamesService const&, edm::PreallocationConfiguration const&, edm::ProcessContext const*, edm::ModuleTypeResolverMaker const*) () from /data/user/fwyzard/disable_ROOT_automatic_class_parsing/CMSSW_15_0_0_pre3/lib/el8_amd64_gcc12/libFWCoreFramework.so
#28 0x00007ffff7c012a7 in tbb::detail::d1::function_task<edm::EventProcessor::init(std::shared_ptr<edm::ProcessDesc>&, edm::ServiceToken const&, edm::serviceregistry::ServiceLegacy)::{lambda()#1}>::execute(tbb::detail::d1::execution_data&) [clone .lto_priv.0] () from /data/user/fwyzard/disable_ROOT_automatic_class_parsing/CMSSW_15_0_0_pre3/lib/el8_amd64_gcc12/libFWCoreFramework.so
#29 0x00007ffff7e313e1 in tbb::detail::r1::task_dispatcher::local_wait_for_all<false, tbb::detail::r1::external_waiter> (waiter=..., t=<optimized out>, this=0x7ffff40c3e00) at /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc12/external/tbb/v2021.9.0-9b0f135342cfe979b6500c59f501774e/tbb-v2021.9.0/src/tbb/task_dispatcher.h:322
#30 tbb::detail::r1::task_dispatcher::local_wait_for_all<tbb::detail::r1::external_waiter> (waiter=..., t=<optimized out>, this=0x7ffff40c3e00) at /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc12/external/tbb/v2021.9.0-9b0f135342cfe979b6500c59f501774e/tbb-v2021.9.0/src/tbb/task_dispatcher.h:458
#31 tbb::detail::r1::task_dispatcher::execute_and_wait (t=<optimized out>, wait_ctx=..., w_ctx=...) at /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc12/external/tbb/v2021.9.0-9b0f135342cfe979b6500c59f501774e/tbb-v2021.9.0/src/tbb/task_dispatcher.cpp:168
#32 0x00007ffff7bcd21f in edm::EventProcessor::init(std::shared_ptr<edm::ProcessDesc>&, edm::ServiceToken const&, edm::serviceregistry::ServiceLegacy) () from /data/user/fwyzard/disable_ROOT_automatic_class_parsing/CMSSW_15_0_0_pre3/lib/el8_amd64_gcc12/libFWCoreFramework.so
#33 0x00007ffff7bd0718 in edm::EventProcessor::EventProcessor(std::shared_ptr<edm::ProcessDesc>, edm::ServiceToken const&, edm::serviceregistry::ServiceLegacy) () from /data/user/fwyzard/disable_ROOT_automatic_class_parsing/CMSSW_15_0_0_pre3/lib/el8_amd64_gcc12/libFWCoreFramework.so
#34 0x0000000000408369 in tbb::detail::d1::task_arena_function<main::{lambda()#1}::operator()() const::{lambda()#1}, void>::operator()() const ()
#35 0x00007ffff7e1d9ad in tbb::detail::r1::task_arena_impl::execute (ta=..., d=warning: RTTI symbol not found for class 'tbb::detail::d1::task_arena_function<main::{lambda()#1}::operator()() const::{lambda()#1}, void>'
...) at /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc12/external/tbb/v2021.9.0-9b0f135342cfe979b6500c59f501774e/tbb-v2021.9.0/src/tbb/arena.cpp:688
#36 0x000000000040a283 in main::{lambda()#1}::operator()() const ()
#37 0x00000000004051b8 in main ()

cmsbuild added this to the CMSSW_15_0_X milestone Dec 3, 2024

cmsbuild added core-pending pending-signatures tests-pending orp-pending code-checks-pending labels Dec 3, 2024

cmsbuild added tests-started and removed tests-pending labels Dec 3, 2024

cmsbuild added code-checks-approved and removed code-checks-pending labels Dec 3, 2024

fwyzard changed the title ~~Disable ROOT automatic class parsing~~ Disable ROOT automatic class parsing during ScheduleItems::finishSchedule() Dec 3, 2024

fwyzard changed the title ~~Disable ROOT automatic class parsing during ScheduleItems::finishSchedule()~~ Disable ROOT automatic class parsing during finishSchedule() Dec 3, 2024

fwyzard changed the title ~~Disable ROOT automatic class parsing during finishSchedule()~~ Disable ROOT automatic class parsing during finishSchedule() Dec 3, 2024

fwyzard changed the title ~~Disable ROOT automatic class parsing during finishSchedule()~~ Disable ROOT automatic class parsing during finishSchedule() Dec 3, 2024

cmsbuild added tests-approved and removed tests-started labels Dec 3, 2024

fwyzard force-pushed the disable_ROOT_automatic_class_parsing branch from 054f633 to 5d0a065 Compare December 10, 2024 13:47

cmsbuild removed tests-approved code-checks-approved labels Dec 10, 2024

fwyzard added 2 commits February 19, 2025 08:52

Disable ROOT automatic class parsing while checking for missing dicti…

fc55348

…onaries

Add a test for missing dictionaries with CUDA headers

568c8b1

Add a test to check that the framework handles correctly the case of edm::Wrapper<T> where: - T has a dictionary - edm::Wrapper<T> does not have a dictionary - the corresponding classes.h file includes CUDA headers

fwyzard force-pushed the disable_ROOT_automatic_class_parsing branch from ac20e4b to 568c8b1 Compare February 19, 2025 07:52

cmsbuild added tests-pending code-checks-pending heterogeneous-pending changes-dataformats and removed tests-rejected code-checks-approved labels Feb 19, 2025

cmsbuild added code-checks-approved and removed code-checks-pending labels Feb 19, 2025

cmsbuild added tests-started and removed tests-pending labels Feb 20, 2025

cmsbuild added tests-rejected and removed tests-started labels Feb 20, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Disable ROOT automatic class parsing during finishSchedule() #46858

Disable ROOT automatic class parsing during finishSchedule() #46858

fwyzard commented Dec 3, 2024 •

edited

Loading

cmsbuild commented Dec 3, 2024 •

edited

Loading

fwyzard commented Dec 3, 2024

cmsbuild commented Dec 3, 2024

makortel commented Dec 3, 2024

cmsbuild commented Dec 3, 2024

makortel commented Dec 3, 2024

fwyzard commented Dec 3, 2024

wddgit commented Dec 3, 2024

cmsbuild commented Dec 3, 2024

Dr15Jones commented Dec 4, 2024

fwyzard commented Dec 10, 2024

fwyzard commented Feb 18, 2025

Dr15Jones commented Feb 18, 2025

fwyzard commented Feb 18, 2025

fwyzard commented Feb 18, 2025

fwyzard commented Feb 18, 2025

fwyzard commented Feb 18, 2025

fwyzard commented Feb 19, 2025

fwyzard commented Feb 19, 2025

cmsbuild commented Feb 19, 2025

cmsbuild commented Feb 19, 2025

fwyzard commented Feb 19, 2025

makortel commented Feb 20, 2025

makortel commented Feb 20, 2025

cmsbuild commented Feb 20, 2025

fwyzard commented Feb 21, 2025

Disable ROOT automatic class parsing during finishSchedule() #46858

Are you sure you want to change the base?

Disable ROOT automatic class parsing during finishSchedule() #46858

Conversation

fwyzard commented Dec 3, 2024 • edited Loading

PR description:

PR validation:

cmsbuild commented Dec 3, 2024 • edited Loading

fwyzard commented Dec 3, 2024

cmsbuild commented Dec 3, 2024

makortel commented Dec 3, 2024

cmsbuild commented Dec 3, 2024

makortel commented Dec 3, 2024

fwyzard commented Dec 3, 2024

wddgit commented Dec 3, 2024

cmsbuild commented Dec 3, 2024

Comparison Summary

Dr15Jones commented Dec 4, 2024

fwyzard commented Dec 10, 2024

fwyzard commented Feb 18, 2025

Dr15Jones commented Feb 18, 2025

fwyzard commented Feb 18, 2025

fwyzard commented Feb 18, 2025

fwyzard commented Feb 18, 2025

fwyzard commented Feb 18, 2025

fwyzard commented Feb 19, 2025

fwyzard commented Feb 19, 2025

cmsbuild commented Feb 19, 2025

cmsbuild commented Feb 19, 2025

fwyzard commented Feb 19, 2025

makortel commented Feb 20, 2025

makortel commented Feb 20, 2025

cmsbuild commented Feb 20, 2025

Unit Tests

Comparison Summary

fwyzard commented Feb 21, 2025

fwyzard commented Dec 3, 2024 •

edited

Loading

cmsbuild commented Dec 3, 2024 •

edited

Loading