Clean-up Phase-2 HLT menu of duplicates

[mmusich]

PR description:

As reported here some duplicates (instances of the same ED module that are configured exactly in the same way down to the last parameter but have different labels) were found in the Phase 2 menu.
The full list can be found with the following commands

cmsrel CMSSW_15_0_X_2025-01-20-1100
cd CMSSW_15_0_X_2025-01-20-1100/src/
cmsenv
hltPhase2UpgradeIntegrationTests --dryRun
more hlt_test_configs/Phase2_dump.py | hltFindDuplicates
more hltFindDuplicates_output/groups.txt

here:

Click me

# CandidateSeededTrackingRegionsEDProducer (hltPhase2L3MuonHighPtTripletStepTrackingRegions)
hltPhase2L3MuonHighPtTripletStepTrackingRegions
hltPhase2L3MuonPixelTracksTrackingRegions

# ChainedJetCorrectorProducer (hltAK4PFCHSJetCorrector)
hltAK4PFCHSJetCorrector
hltPFMETJetCorrector

# EGammaSuperclusterProducer (hltTiclEGammaSuperClusterProducerL1Seeded)
hltTiclEGammaSuperClusterProducerL1Seeded
hltTiclEGammaSuperClusterProducerUnseeded
ticlEGammaSuperClusterProducer

# EgammaHLTElectronTrackIsolationProducers (hltEgammaEleGsfTrackIsoL1Seeded)
hltEgammaEleGsfTrackIsoL1Seeded
hltEgammaEleGsfTrackIsoV6L1Seeded

# EgammaHLTElectronTrackIsolationProducers (hltEgammaEleGsfTrackIsoUnseeded)
hltEgammaEleGsfTrackIsoUnseeded
hltEgammaEleGsfTrackIsoV6Unseeded

# FixedGridRhoProducerFastjet (hltFixedGridRhoFastjetAllTmp)
hltFixedGridRhoFastjetAllTmp
hltFixedGridRhoProducerFastjetAllTau

# L1FastjetCorrectorProducer (hltAK4PFCHSJetCorrectorL1)
hltAK4PFCHSJetCorrectorL1
hltPFMETJetCorrectorL1

# LXXXCorrectorProducer (hltAK4PFCHSJetCorrectorL2)
hltAK4PFCHSJetCorrectorL2
hltPFMETJetCorrectorL2

# LXXXCorrectorProducer (hltAK4PFCHSJetCorrectorL3)
hltAK4PFCHSJetCorrectorL3
hltPFMETJetCorrectorL3

# PFRecHitProducer (hltParticleFlowRecHitECAL)
hltParticleFlowRecHitECAL
hltParticleFlowRecHitECALUnseeded

The goal of this PR is to reduce the amount of duplication for the modules that have been uncontroversially identified as superfluous. Few other more specific ones to e/gamma reconstruction at HLT are discussed in this issue #47145:
After this PR the modules remaining to be addressed are:

# PFRecHitProducer (hltParticleFlowRecHitECAL)
hltParticleFlowRecHitECAL
hltParticleFlowRecHitECALUnseeded

PR validation:

• hltPhase2UpgradeIntegrationTests runs fine with this branch.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

N/A

[cmsbuild]

cms-bot internal usage

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47144/43371

[mmusich]

test parameters:

• enable = hlt_p2_integration, hlt_p2_timing
• relvals_opt = --what upgrade
• workflows = 29634.751, 29634.752, 29634.753, 29634.754, 29634.755, 29834.0, 29834.777, 29834.778, 29850.0, 29850.777, 29850.778

[mmusich]

@cmsbuild, please test

[VourMa]

@mmusich Thank you for the follow up! I mention some considerations below:

• For the duplication:

  # PFRecHitProducer (hltParticleFlowRecHitECAL)
  hltParticleFlowRecHitECAL
  hltParticleFlowRecHitECALUnseeded
  

  I believe we can go with hltParticleFlowRecHitECALUnseeded, as opposed to hltParticleFlowRecHitECALL1Seeded. "Unseeded" and "L1Seeded" do not seem to be duplicates in this case, so we seem to be fine.

• For the duplication:

  # FixedGridRhoProducerFastjet (hltFixedGridRhoFastjetAllTmp)
  hltFixedGridRhoFastjetAllTmp
  hltFixedGridRhoProducerFastjetAllTau
  

  I understand that "Tmp" stands for temporary. If that's the case, perhaps we can rename both of the above to hltFixedGridRhoFastjetAll.

• For the duplication:

  # CandidateSeededTrackingRegionsEDProducer (hltPhase2L3MuonHighPtTripletStepTrackingRegions)
  hltPhase2L3MuonHighPtTripletStepTrackingRegions
  hltPhase2L3MuonPixelTracksTrackingRegions
  

  For this one, I would like to tag @BlancoFS and @kyHwangs because I have understood that the Muon POG was working on a similar renaming, so they should take note of this.

[mmusich]

I mention some considerations below:

thanks Manos, I'll push the changes concerning your first two bullets after tests are done (also renaming the tracking sequence to remove V61 as agreed earlier).

[cmsbuild]

-1

Failed Tests: RelVals
Size: This PR adds an extra 56KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f94222/43869/summary.html
COMMIT: 1aa9bd8
CMSSW: CMSSW_15_0_X_2025-01-20-1100/el8_amd64_gcc12
Additional Tests: HLT_P2_INTEGRATION,HLT_P2_TIMING
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/47144/43869/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

ValueError: Undefined workflows: 29634.751, 29634.752, 29634.753, 29634.754, 29634.755, 29850.0, 29850.777, 29834.0, 29834.777, 29834.778, 29850.778

• HLT P2 Timing: chart

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47144/43375

• There are other open Pull requests which might conflict with changes you have proposed:
  • File HLTrigger/Configuration/python/HLT_75e33/sequences/HLTTrackingV61Sequence_cfi.py modified in PR(s): add vertex trimming to the phase2 hlt tracking iterations #47113

[cmsbuild]

Pull request #47144 was updated.

[mmusich]

test parameters:

• enable = hlt_p2_integration, hlt_p2_timing
• relvals_opt = --what upgrade
• workflows = 29634.751, 29634.752, 29634.753, 29634.754, 29634.755, 29834.0, 29834.777, 29834.778, 29850.0, 29850.777, 29850.778

[mmusich]

@cmsbuild, please test

[cmsbuild]

+1

Size: This PR adds an extra 220KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f94222/43872/summary.html
COMMIT: 4e94d95
CMSSW: CMSSW_15_0_X_2025-01-20-1100/el8_amd64_gcc12
Additional Tests: HLT_P2_INTEGRATION,HLT_P2_TIMING
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/47144/43872/install.sh to create a dev area with all the needed externals and cmssw changes.

• HLT P2 Timing: chart

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3819085
• DQMHistoTests: Total failures: 63
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3819002
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
• Checked 214 log files, 184 edm output root files, 49 DQM output files
• TriggerResults: found differences in 6 / 47 workflows

[VourMa]

Thanks for the updates, @mmusich, the changes look good to me.

[cmsbuild]

A new Pull Request was created by @mmusich for master.

It involves the following packages:

• HLTrigger/Configuration (hlt)

@Martin-Grunewald, @mmusich can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @ReyerBand, @SohamBhattacharya, @VourMa, @argiro, @missirol, @rchatter, @rovere, @thomreis, @wang0jin this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

[mmusich]

+hlt

• see Clean-up Phase-2 HLT menu of duplicates #47144 (comment)
• changes in TriggerResults link due to module execution reordering and do not affect final trigger decisions.

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @antoniovilela, @rappoccio, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

[mandrenguyen]

+1