Remove duplication of configuration of EGammaSuperclusterProducer in the Phase-2 HLT menu

[mmusich]

fixes #47145

PR description:

Title says it all. Addresses the "duplication" (even though the modules are not actually scheduled) of EGammaSuperclusterProducer modules configured with the same parameters in the Phase-2 HLT menu, by changing the InputTags of hltTiclEGammaSuperClusterProducerL1Seeded and hltTiclEGammaSuperClusterProducerUnseeded directly in the clone of the offline configuration, instead of within the toModify calls of the process modifiers (commit fa54d43), such that two fully independent configuration are.
In the other commit 8cf3728, I introduce a new unit test aimed to catch any possible duplicates in the Phase-2 HLT menu and fail in case it finds any.

PR validation:

scram b runtests_test_check_phase2_hlt_duplicates

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

N/A

Cc:

@rovere @waredjeb

[cmsbuild]

cms-bot internal usage

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47286/43602

[cmsbuild]

A new Pull Request was created by @mmusich for master.

It involves the following packages:

• HLTrigger/Configuration (hlt)

@Martin-Grunewald, @cmsbuild, @mmusich can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @SohamBhattacharya, @VourMa, @missirol, @rovere this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

[mmusich]

@cmsbuild, please test

[cmsbuild]

-1

Failed Tests: UnitTests
Size: This PR adds an extra 28KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7f71bd/44242/summary.html
COMMIT: fa54d43
CMSSW: CMSSW_15_0_X_2025-02-06-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/47286/44242/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found 1 errors in the following unit tests:

---> test test_check_phase2_hlt_duplicates had ERRORS

Comparison Summary

Summary:

• You potentially removed 2 lines from the logs
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 4016960
• DQMHistoTests: Total failures: 45
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 4016895
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
• Checked 218 log files, 189 edm output root files, 50 DQM output files
• TriggerResults: no differences found

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47286/43606

[cmsbuild]

Pull request #47286 was updated. @Martin-Grunewald, @cmsbuild, @mmusich can you please check and sign again.

[mmusich]

please test

[cmsbuild]

Pull request #47286 was updated. @Martin-Grunewald, @cmsbuild, @mmusich can you please check and sign again.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47286/43609

[cmsbuild]

Pull request #47286 was updated. @Martin-Grunewald, @cmsbuild, @mmusich can you please check and sign again.

[mmusich]

please test

[cmsbuild]

+1

Size: This PR adds an extra 28KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7f71bd/44261/summary.html
COMMIT: 5a907b7
CMSSW: CMSSW_15_0_X_2025-02-06-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/47286/44261/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 4 lines to the logs
• Reco comparison results: 6 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 4016960
• DQMHistoTests: Total failures: 127
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 4016813
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
• Checked 218 log files, 189 edm output root files, 50 DQM output files
• TriggerResults: no differences found

[mmusich]

+hlt

• no regession expected, none seen.

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @antoniovilela, @sextonkennedy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[mandrenguyen]

+1

[waredjeb]

thanks @mmusich !