[Backport 15_0_X] Restriction of reemul fg0 in ieta16 #47415
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A new Pull Request was created by @hazeltet845 for CMSSW_15_0_X. It involves the following packages:
@aloeliger, @cmsbuild, @epalencia can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
cms-bot internal usage |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description:
Based on logic in the HB uHTR firmware, the depth bit will always be 0 in abs(ieta) == 16. The depth bit is set in the emulator in file
SimCalorimetry/HcalTrigPrimAlgos/src/HcalFinegrainBit.cc. There was no restriction on abs(ieta) == 16, causing the depth bit to be set in the emulator in this region. A restriction was added to the emulator to match the firmware. Slides explaining the issues and showing changes to the depth bit in abs(ieta) == 16 are provided below.Hazelton_reemul_fix.pdf
PR validation:
Passed runTheMatrix.py tests. Tested in CMSSW_15_0_X_2025-02-04-2300.
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
Backporting PR #47283 to 15_0_X to show better agreement in the HCAL DQM plot between data and emulator in early 2025 data taking. @gk199 @JHiltbrand