Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[15_0] ZS added to L1TCaloLayer1 #47433

Open
wants to merge 10 commits into
base: CMSSW_15_0_X
Choose a base branch
from

Conversation

aloeliger
Copy link
Contributor

backport of #47341

PR description:

Taken from original PR description:

This PR should allow for ZeroSuppression of the Trigger Primitives at the input of L1TCaloLayer1. It passed basic tests.

PR validation:

Original PR merged

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

This PR is a backport to 15_0 for use in studies/emulation in data taking.

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 24, 2025

A new Pull Request was created by @aloeliger for CMSSW_15_0_X.

It involves the following packages:

  • L1Trigger/L1TCaloLayer1 (l1)
  • L1Trigger/L1TCalorimeter (l1)

@aloeliger, @cmsbuild, @epalencia can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol, @mmusich this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 24, 2025

cms-bot internal usage

@aloeliger
Copy link
Contributor Author

please test

@aloeliger
Copy link
Contributor Author

Before I forget, @missirol FYI

@missirol
Copy link
Contributor

Thanks @aloeliger !

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 20KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-986b68/44611/summary.html
COMMIT: 0276bfc
CMSSW: CMSSW_15_0_X_2025-02-24-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/47433/44611/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 2 lines to the logs
  • Reco comparison results: 6 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 4018889
  • DQMHistoTests: Total failures: 41
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 4018828
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
  • Checked 218 log files, 189 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@aloeliger
Copy link
Contributor Author

+l1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_15_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_15_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @mandrenguyen, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants