Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates for condor on CMS Connect in singularity #3845

Open
wants to merge 4 commits into
base: mg265UL
Choose a base branch
from

Conversation

bryates
Copy link

@bryates bryates commented Feb 5, 2025

This PR fixes condor on CMS Connect. The cmssw-cc7-condor-python27 singularity container is required to run, and must be activated from the top genproductions directory.

@@ -581,6 +585,10 @@ make_gridpack () {
echo "cleaning temporary gridpack"
rm $WORKDIR/pilotrun_gridpack.tar.gz

# awightma start: Force the re-weight step to only use 1 core
echo "nb_core = 1" >> $WORKDIR/process/madevent/Cards/me5_configuration.txt
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this does not affect phase space integration?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, this is the step after when EFT reweighting is done. I can remove this too since it's not for general use.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is due to a bug in madgraph that doesn't work when nb_core is not 1? If so, it might be worth keeping it

@@ -694,6 +703,8 @@ else
cmssw_version=CMSSW_10_2_24_patch1
elif [[ $SYSTEM_RELEASE == *"release 7"* ]]; then
cmssw_version=CMSSW_10_6_19
elif [[ $SYSTEM_RELEASE == *"release 9"* ]]; then
cmssw_version=CMSSW_13_2_9
Copy link
Collaborator

@sihyunjeon sihyunjeon Feb 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

el9 gridpacks won't work for official production yet (that's why we just didn't care about el9 so much in the script), or is the container-in-container prepared? @DickyChant

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should officially disable el9 instead of making it work like this (el9 gridpacks are not going to be usable for official production) , talked to sitian

if [ -e "$input_files" ]; then rm "$input_files"; fi
tar -zchf "$input_files" "$card_dir" "$patches_directory" "$utilities_dir" "${plugin_directory}"
tar -zchf "$input_files" "$card_dir" "$patches_directory" "$utilities_dir" "${plugin_directory}" "${addons_dir}"
Copy link
Collaborator

@sihyunjeon sihyunjeon Feb 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is not safe since not all people are going to be using a model that lives under addons directory and tar command will eventually crash if it does not exist. why not just steer it with extramodels.dat ?

e.g.
https://github.com/cms-sw/genproductions/blob/master/bin/MadGraph5_aMCatNLO/cards/production/13TeV/SingleLepton_TypeIHeavyN/DYtoLNuJJ/DYtoLNuJJ_TypeIHeavyN-El_MN500_TuneCP5_13TeV-amcatnlo-pythia8/DYtoLNuJJ_TypeIHeavyN-El_MN500_TuneCP5_13TeV-amcatnlo-pythia8_extramodels.dat

this will be wgetted from link

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for explaining, I've removed this. Our current model is not in https://cms-project-generators.web.cern.ch/cms-project-generators/. Can we add it or can only people in the gen group make changes?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should ask GEN conveners

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants