Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Missing icons unit test expansion (#7659)
# About the pull request This PR is an experimental change to the missing icons unit test where it now instantiates all items to check their items (meaning they will do whatever they do to their icon_state in Initialize). This ended up causing several new hard deletes that I had to fix too. The create and destroy unit test shares exclusions now with missing icons. I originally started this because #7021 is likely going to need help sorting out lots of missing icons at runtime that weren't caught with the old unit test. ~~No actual pixel changes in sprites: Just renames, removals, or addition of blank states.~~ Added unlocked overlay to `/obj/item/storage/backpack/satchel/lockable` ![image](https://github.com/user-attachments/assets/d4a47ee9-6033-4667-b001-2169a68ec2c6) Restored the spike overlays to `/obj/item/weapon/gun/launcher/spike` removed some reason in #7361 ![image](https://github.com/user-attachments/assets/4711b856-598d-44f2-8ff3-ff60447254c5) Tweaked transparency and edges on old alien samples: ![image](https://github.com/user-attachments/assets/ea30a8d0-491a-4b97-8584-247c67176d52) Currently there are 847 warnings for missing mob icons (could be more if blanket testing slots that allow equipping the item), but these are only mentioned in the warnings section (nor annotated currently though I would like warnings to eventually be annotated once there isn't so much noise). # Explain why it's good for the game More robust testing for hard deletes and missing icons. # Testing Photographs and Procedure <details> <summary>Screenshots & Videos</summary> https://youtu.be/uB8Z4yNjfDA </details> # Changelog :cl: Drathek code: Missing Icons unit test now instantiates items and generally tests more icon_states code: Unit tests can now log warnings that appear as a separate collapsed list but do not fail checks fix: Fixed various hardrefs and missing icons fix: Pipes retain their dir when picked up, no longer go invisible when re-anchored, and reconnect when re-anchored. fix: Disabled various admin only pistols from being equipped in pistol belts since they only honk their underlay refactor: Giant lizards and parent types now use weakrefs refactor: Removed has_gamemode_skin and renamed NO_SNOW_TYPE to NO_GAMEMODE_SKIN refactor: Removed uses_skin_color in favor of the existing flag HAS_SKIN_COLOR maptweak: Fixed droppod floors on trijent elevator, lifeboats, corsat, and bigred imageadd: Added missing unlocked overlay to lockable satchel imageadd: Restored the missing overlays to spike launcher imageadd: Tweaked the old sample jars and samples admin: Admin spawned predators now have random skin color /:cl:
- Loading branch information