-
Notifications
You must be signed in to change notification settings - Fork 622
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FORECON ERT Doesn't have FORECON comms. #7918
Labels
Comments
Hey, I looked into this. It seems that they do have access. If I test it on local it is their default frequency so ; has to be used. This is also the case for all ert's. |
github-merge-queue bot
pushed a commit
that referenced
this issue
Jan 2, 2025
# About the pull request Tl:DR: If you examine your headset the same ui will pop up that pops up when you normally click it. Shift click a headset to examine it. And it will have a pop up listing it's frequencies open up. The pop up shows you all frequencies it has and is always updated based upon the keys inserted. The first line I override the examine proc. The second line we ensure you cannot remotely interact with it. Or get the menu if you normally would not get the menu. So a shift click cannot be used to bypass checks on the pop up. Such as remote interaction from far away. Yautja and synths still/also get the pop up. Next we ensure we stop updating changes if the user closes the window. Then we open the window. And last we make sure to always call the parent proc so that we also display the description. It also fixes "Fixes issue #7918 " # Explain why it's good for the game This is good because currently the channels are listed in the description when clicking the headset. Now, there is no need to manually add it to each headset it's description. And it updates when keys are inserted or removed. Currently, some descriptions are missing some channels. And some headsets do not have any channels in their description. This helps also helps newer players, because it's more obvious, always correct/self updating. Because it's a pop up it won't get lost in the chat log and is also easier to see/write down. # Testing Photographs and Procedure Unless I also managed to tape my inputs you would not know what buttons I was pressing. But, I spawned in as Human and shift clicked a headset in my hand, one I was wearing, one in a backpack and one on the floor twice. Once next to me and once remotely. I got the expected result each time. I also did the same as a synth, a yautja and a monkey. The results were as expected. As a xeno I could not pick it up only slash it. # Changelog :cl:Awan qol: If you examine a radio that is on your person it's menu listing all frequencies will now pop up. /:cl:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Testmerges
#7536: 'Adds crosshairs to all ranged weapons' by VileBeggar at commit d8bd7437c4
#7766: 'lobby screen update' by harryob at commit 61b278ed88
#7754: 'Adds Watchtowers' by Git-Nivrak at commit 61479579ab
#7802: 'Removes non combat click delay' by Git-Nivrak at commit add0b48a4b
#7607: 'Warden Praetorian rework (tm)' by Red-byte3D at commit 6679548f3b
#7600: 'SG Frontline Mode & Friends - Yay!!!' by BasilHerb at commit cfdd191899
#7743: 'Ship Operations Synthetic' by QuickLode at commit ac99415374
#7764: '[TM only] Snowflake_SnowCap' by HIDgamer at commit 364f8cccd3
#7165: 'Fax Responders TestMerge Collection' by realforest2001 at commit 3543d15488
#7901: 'Adds a speed penalty to incomplete Yautja field surgery.' by realforest2001 at commit 3c7eab0096
#7774: 'req console tgui' by harryob at commit a04d077fca
#7242: 'WIP Yautja Clan TGUI Menu' by realforest2001 at commit 636f4413af
#7568: 'adds a tgui for the pred preferences menu' by harryob at commit 130b54381e
#7909: 'Fixes maintainer access to the profiler and clears profiler access whenever admins are loaded.' by Watermelon914 at commit 6f3a0a64f4
#7910: 'Reboot Reason Ignore' by Drulikar at commit 7c172230f1
#7913: 'Fixes santa hat inhands + makes it hide only top hair' by Blundir at commit a89b56b14f
Round ID
25571
Description of the bug
FORECON ERT has every comms channel apart from SOF.
What's the difference with what should have happened?
FORECON should have SOF comms, as do FORECON survivors.
How do we reproduce this bug?
Attached logs
Additional details
The text was updated successfully, but these errors were encountered: