Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show all channels a headset has on examining it. #7943

Merged
merged 3 commits into from
Jan 2, 2025

Conversation

Awantje
Copy link
Contributor

@Awantje Awantje commented Dec 29, 2024

About the pull request

Tl:DR: If you examine your headset the same ui will pop up that pops up when you normally click it.

Shift click a headset to examine it. And it will have a pop up listing it's frequencies open up.
The pop up shows you all frequencies it has and is always updated based upon the keys inserted.

The first line I override the examine proc.
The second line we ensure you cannot remotely interact with it. Or get the menu if you normally would not get the menu.
So a shift click cannot be used to bypass checks on the pop up. Such as remote interaction from far away. Yautja and synths still/also get the pop up.
Next we ensure we stop updating changes if the user closes the window.
Then we open the window.
And last we make sure to always call the parent proc so that we also display the description.
It also fixes "Fixes issue #7918 "

Explain why it's good for the game

This is good because currently the channels are listed in the description when clicking the headset.
Now, there is no need to manually add it to each headset it's description. And it updates when keys are inserted or removed.
Currently, some descriptions are missing some channels. And some headsets do not have any channels in their description.
This helps also helps newer players, because it's more obvious, always correct/self updating.
Because it's a pop up it won't get lost in the chat log and is also easier to see/write down.

Testing Photographs and Procedure

Unless I also managed to tape my inputs you would not know what buttons I was pressing.
But, I spawned in as Human and shift clicked a headset in my hand, one I was wearing, one in a backpack and one on the floor twice. Once next to me and once remotely. I got the expected result each time. I also did the same as a synth, a yautja and a monkey. The results were as expected. As a xeno I could not pick it up only slash it.

Changelog

🆑Awan
qol: If you examine a radio that is on your person it's menu listing all frequencies will now pop up.
/:cl:

When you examine a headset it will now have it's ui pop up. If it is on your person.
@cmss13-ci cmss13-ci bot added the Quality of Life Make the game harder to play label Dec 29, 2024
@Awantje
Copy link
Contributor Author

Awantje commented Dec 29, 2024

Now, for a follow up question. Isn't having the channels listed in the description kinda redundant now?
I did it this way because it is future proof. Instead of manually having to edit/update descriptions.
But as stated there is still headsets that do not (correctly) list their channels.
The only reason I did not remove it is because currently you can examine from a distance and see the description.
If I remove the strings in the desc variables you can no longer from a distance see what channels a headset has.

@hry-gh
Copy link
Member

hry-gh commented Dec 30, 2024

the title of your pr needs to say what you're trying to fix, or accomplish

@hry-gh hry-gh marked this pull request as draft December 30, 2024 18:05
@Awantje Awantje changed the title Update headset.dm Show all channels a headset has on examine.dm Dec 30, 2024
@Awantje Awantje changed the title Show all channels a headset has on examine.dm Show all channels a headset has on examining it. Dec 30, 2024
@Awantje Awantje marked this pull request as ready for review December 30, 2024 22:44
@Awantje
Copy link
Contributor Author

Awantje commented Dec 30, 2024

the title of your pr needs to say what you're trying to fix, or accomplish

Sorry, my bad. Fixed it.

@hry-gh
Copy link
Member

hry-gh commented Dec 31, 2024

the title of your pr needs to say what you're trying to fix, or accomplish

Sorry, my bad. Fixed it.

you’re all good, the title is just the name of the squash commit when we merge the pr - best it’s helpful!

@hry-gh hry-gh marked this pull request as draft December 31, 2024 11:35
@Awantje Awantje marked this pull request as ready for review December 31, 2024 20:07
@Awantje Awantje requested a review from hry-gh December 31, 2024 20:07
@hry-gh hry-gh added this pull request to the merge queue Jan 2, 2025
Merged via the queue into cmss13-devs:master with commit bbe2710 Jan 2, 2025
29 checks passed
cmss13-ci bot added a commit that referenced this pull request Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Quality of Life Make the game harder to play
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants