Makes SOF Keys have SOF encryption. #7618
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harryob
requested changes
Nov 19, 2024
harryob
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the pull request
SOF keys didn't grant you SOF encryption, meaning that even if you put them in a new headset you couldn't speak over SOF comms.
This is most noticeable for Forecon who are forced to keep their SOF headsets if they want to communicate with eachother after being rescued (instead of dropping their headsets for a marine one).
Explain why it's good for the game
Encryption keys should give the relevant comms channel, instead of it being tied to the headset alone?
Testing Photographs and Procedure
Screenshots & Videos
Put screenshots and videos here with an empty line between the screenshots and the
<details>tags.Changelog
🆑
fix: SOF Encryption Keys now properly give you SOF comms.
/:cl: