Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds poll subsystem, entities and ui #7645

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

harryob
Copy link
Member

@harryob harryob commented Nov 21, 2024

polls and stuff

in order to most effectively ignore player feedback, we need to know what players want more

🆑
add: added a poll button to the lobby screen. engage democratically.
/:cl:

@cmss13-ci cmss13-ci bot added UI deletes nanoui/html Feature Feature coder badge labels Nov 21, 2024
@harryob harryob requested a review from fira as a code owner November 22, 2024 16:46
/datum/controller/subsystem/polls/proc/handle_new_user(source, client/new_client)
SIGNAL_HANDLER

INVOKE_ASYNC(src, PROC_REF(remind_new_user), new_client)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think you need to INVOKE_ASYNC since it's waitfor = FALSE anyway

Comment on lines +109 to +110
while(!new_client.player_data)
stoplag()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UNTIL(new_client.player_data)

but honestly it could be useful to just strap signaling in load_player_data_info

code/datums/soundOutput.dm Show resolved Hide resolved
@cm13-github cm13-github added the Merge Conflict PR can't be merged because it touched too much code label Jan 2, 2025
@cm13-github
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@cmss13-ci
Copy link
Contributor

cmss13-ci bot commented Jan 23, 2025

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@cmss13-ci cmss13-ci bot added the Stale beg a maintainer to review your PR label Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Feature coder badge Merge Conflict PR can't be merged because it touched too much code Stale beg a maintainer to review your PR UI deletes nanoui/html
Projects
Status: Awaiting Review
Development

Successfully merging this pull request may close these issues.

4 participants