-
Notifications
You must be signed in to change notification settings - Fork 604
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adds poll subsystem, entities and ui #7645
base: master
Are you sure you want to change the base?
Conversation
/datum/controller/subsystem/polls/proc/handle_new_user(source, client/new_client) | ||
SIGNAL_HANDLER | ||
|
||
INVOKE_ASYNC(src, PROC_REF(remind_new_user), new_client) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think you need to INVOKE_ASYNC since it's waitfor = FALSE anyway
while(!new_client.player_data) | ||
stoplag() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
UNTIL(new_client.player_data)
but honestly it could be useful to just strap signaling in load_player_data_info
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself |
polls and stuff
in order to most effectively ignore player feedback, we need to know what players want more
🆑
add: added a poll button to the lobby screen. engage democratically.
/:cl: