Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fax Responder Names, Announcements and Huds #7658

Merged
merged 14 commits into from
Dec 15, 2024

Conversation

realforest2001
Copy link
Member

@realforest2001 realforest2001 commented Nov 22, 2024

About the pull request

Allows people to set preferences for differing names for each fax responder role. This will not change appearance or physical gender at the moment.

Explain why it's good for the game

Ideally I'd rather people not use main names but I'm not against it. This also makes it easier to have different names for different factions without a lot of hassle.

Testing Photographs and Procedure

Screenshots & Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑
add: Added Fax Responder name preferences in Special Roles section of character preferences.
add: Added the correct factions to Fax Responder faction_groups, so they get correct announcements.
add: Added health huds to Fax Responders.
/:cl:

@cmss13-ci cmss13-ci bot added the Feature Feature coder badge label Nov 22, 2024
code/modules/client/preferences.dm Outdated Show resolved Hide resolved
code/modules/client/preferences.dm Outdated Show resolved Hide resolved
code/modules/client/preferences.dm Outdated Show resolved Hide resolved
code/modules/client/preferences.dm Outdated Show resolved Hide resolved
@harryob harryob marked this pull request as draft November 24, 2024 21:19
Copy link
Member

@harryob harryob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't need as

code/modules/client/preferences.dm Outdated Show resolved Hide resolved
code/modules/client/preferences.dm Outdated Show resolved Hide resolved
@realforest2001 realforest2001 changed the title Fax Responder unique names. Fax Responder Nams, Announcements and Huds Nov 25, 2024
@realforest2001 realforest2001 changed the title Fax Responder Nams, Announcements and Huds Fax Responder Names, Announcements and Huds Nov 25, 2024
@realforest2001 realforest2001 added this to the Fax Responders milestone Nov 26, 2024
@realforest2001 realforest2001 marked this pull request as ready for review November 27, 2024 18:24
code/modules/client/preferences.dm Outdated Show resolved Hide resolved
@harryob harryob marked this pull request as draft December 2, 2024 11:52
@realforest2001 realforest2001 marked this pull request as ready for review December 5, 2024 19:08
@harryob harryob added this pull request to the merge queue Dec 15, 2024
Merged via the queue into cmss13-devs:master with commit 83741ad Dec 15, 2024
27 checks passed
cmss13-ci bot added a commit that referenced this pull request Dec 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Feature coder badge
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants