-
Notifications
You must be signed in to change notification settings - Fork 597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hivelord Strain: Designer #7703
base: master
Are you sure you want to change the base?
Hivelord Strain: Designer #7703
Conversation
2650e3f
to
3876c0f
Compare
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
…ivelord-designer-strain
Conflicts have been resolved. A maintainer will review the pull request shortly. |
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
- Added hivelord description and flavor text. - Added Animations for weeds building. - Added New icons for Abilities. cleaned some code.
…ivelord-designer-strain
code/modules/mob/living/carbon/xenomorph/strains/castes/hivelord/designer.dm
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So many spaceeees...
Your code blocks are the same and are a continuation of its execution. There is no need to separate them in such cases, otherwise it creates unnecessary ladders.
Use divisions when you need to specifically separate code blocks indicating the execution of different operations.
I.e.: If you do something with animation, then you have a whole block of code for animation, you should not separate it into pieces and separate lines.
It is the same with checks.
code/modules/mob/living/carbon/xenomorph/strains/castes/hivelord/designer.dm
Outdated
Show resolved
Hide resolved
code/modules/mob/living/carbon/xenomorph/strains/castes/hivelord/designer.dm
Outdated
Show resolved
Hide resolved
code/modules/mob/living/carbon/xenomorph/strains/castes/hivelord/designer.dm
Outdated
Show resolved
Hide resolved
code/modules/mob/living/carbon/xenomorph/strains/castes/hivelord/designer.dm
Outdated
Show resolved
Hide resolved
code/modules/mob/living/carbon/xenomorph/strains/castes/hivelord/designer.dm
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Length() better then .len
code/modules/mob/living/carbon/xenomorph/strains/castes/hivelord/designer.dm
Outdated
Show resolved
Hide resolved
code/modules/mob/living/carbon/xenomorph/strains/castes/hivelord/designer.dm
Outdated
Show resolved
Hide resolved
code/modules/mob/living/carbon/xenomorph/strains/castes/hivelord/designer.dm
Outdated
Show resolved
Hide resolved
code/modules/mob/living/carbon/xenomorph/strains/castes/hivelord/designer.dm
Outdated
Show resolved
Hide resolved
code/modules/mob/living/carbon/xenomorph/strains/castes/hivelord/designer.dm
Outdated
Show resolved
Hide resolved
code/modules/mob/living/carbon/xenomorph/strains/castes/hivelord/designer.dm
Outdated
Show resolved
Hide resolved
code/modules/mob/living/carbon/xenomorph/strains/castes/hivelord/designer.dm
Outdated
Show resolved
Hide resolved
code/modules/mob/living/carbon/xenomorph/strains/castes/hivelord/designer.dm
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OOP...
out-of-date |
0145806
to
c23ff96
Compare
1d3ef0c
to
c9ee1f3
Compare
done. |
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
…ivelord-designer-strain
Conflicts have been resolved. A maintainer will review the pull request shortly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
probably missed something, not cooking today.
@@ -7,6 +7,7 @@ | |||
desc = "Weird black weeds..." | |||
icon = 'icons/mob/xenos/weeds.dmi' | |||
icon_state = "base" | |||
var/icon_state_weeds //Change icon_state for weeds/node subtype. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
new var definition after overrides
return ..() | ||
|
||
/datum/action/xeno_action/activable/design_cost_node/proc/remove_oldest_cost_node(mob/living/carbon/xenomorph/xeno) | ||
if(xeno.cost_node_list.len > 0) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unresolved
About the pull request
Add new Hivelord Strain: Designer
If you want to discuss, join this Project channel on Discord:
https://discord.com/channels/150315577943130112/1306656818071605309
Thanks to vile beggar and gay harry for general help with code and explanation.
Explain why it's good for the game
As Xeno Player, who have 800h as xeno, and spend 150h as builder castes (Hivelord, Drone, Queen) it always made me feel pain, when i spend 20-30min building fortyfications, just for them to be destroyed by CAS spam or OB's, i know its their purpose to create opportunity and destroy blockages, but most people get de-motivated to play as builder, in nearly 50-70% of games, there is no one who want to go hivelord, and the ones who go hivelords are ones who actually "care" to make impact in game.
This create issues like quick game ends, where xenos get rushed to the hive (if even queen cares to build their hives with any reinforcements), this strain is going to change that, in exchange of lacking ability to build, it now do "synergy" where it help other builder castes like: Drone, Hivelord, Whisperer, Queen and Lesser Drones Build.
Designer Abilities:
Far Sight:
Silimar to Whisperer, it was added to this strain, so it can give intel or help Whisperer build.
Design Speed Node:
-Reduces Speed of making structures by 50%
-Speed Buff DO NOT apply on Hivelords (all types)
-Speed Node can be constructed on Semi-weedable, as long as there are weeds present, its because of "Greather Resin
Surge" ability.
Stats:
Design Cost Node:
-Reduces Cost of making structures by 50%
-Cost Reduction only apply on: Resin Walls, Doors, Reflective and Membrane
-Cost Node can be constructed on Semi-weedable, as long as there are weeds present, its because of "Greather Resin Surge" ability.
Stats:
Greater Resin Surge:
-This Ability Replaces all existing Design Nodes like Speed Node and Cost node, with weak resin walls (similar to gardener resin surge).
Stats:
Wall stats:
Designer Summary:
Summary: A Strain That can improve other builders life for exchange of not be able to build by itself, it require other players to make walls/structures, it behaves similar to resin whisperer, so it can build Design nodes on range, but with bigger impact.
Pros:
Cons:
Video and Photos
Screenshots & Videos
2024-12-27.15-23-06.mp4
Changelog
🆑 Venuska1117
add: Add New Hivelord strain: Designer
/:cl: