Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hivelord Strain: Designer #7703

Open
wants to merge 29 commits into
base: master
Choose a base branch
from

Conversation

Venuska1117
Copy link
Contributor

@Venuska1117 Venuska1117 commented Nov 29, 2024

About the pull request

Add new Hivelord Strain: Designer

If you want to discuss, join this Project channel on Discord:
https://discord.com/channels/150315577943130112/1306656818071605309

Thanks to vile beggar and gay harry for general help with code and explanation.

Explain why it's good for the game

As Xeno Player, who have 800h as xeno, and spend 150h as builder castes (Hivelord, Drone, Queen) it always made me feel pain, when i spend 20-30min building fortyfications, just for them to be destroyed by CAS spam or OB's, i know its their purpose to create opportunity and destroy blockages, but most people get de-motivated to play as builder, in nearly 50-70% of games, there is no one who want to go hivelord, and the ones who go hivelords are ones who actually "care" to make impact in game.

This create issues like quick game ends, where xenos get rushed to the hive (if even queen cares to build their hives with any reinforcements), this strain is going to change that, in exchange of lacking ability to build, it now do "synergy" where it help other builder castes like: Drone, Hivelord, Whisperer, Queen and Lesser Drones Build.

Designer Abilities:

Far Sight:
Silimar to Whisperer, it was added to this strain, so it can give intel or help Whisperer build.

Design Speed Node:
-Reduces Speed of making structures by 50%
-Speed Buff DO NOT apply on Hivelords (all types)
-Speed Node can be constructed on Semi-weedable, as long as there are weeds present, its because of "Greather Resin
Surge" ability.

Stats:

  • Plasma Cost: 100
  • Cooldown: 0.5s
  • Ability Windup: 1s
  • Ability Range: 10 Tiles
  • Max Alive Nodes: 6

Design Cost Node:
-Reduces Cost of making structures by 50%
-Cost Reduction only apply on: Resin Walls, Doors, Reflective and Membrane
-Cost Node can be constructed on Semi-weedable, as long as there are weeds present, its because of "Greather Resin Surge" ability.

Stats:

  • Plasma Cost: 125
  • Cooldown: 0.5s
  • Ability Windup: 1s
  • Ability Range: 10 Tiles
  • Max Alive Nodes: 6

Greater Resin Surge:
-This Ability Replaces all existing Design Nodes like Speed Node and Cost node, with weak resin walls (similar to gardener resin surge).

Stats:

  • Plasma Cost: 250
  • Cooldown: 30s
  • Ability Windup: 1s

Wall stats:

  • Health: 100
  • Life duration: 10 seconds.

Designer Summary:

Summary: A Strain That can improve other builders life for exchange of not be able to build by itself, it require other players to make walls/structures, it behaves similar to resin whisperer, so it can build Design nodes on range, but with bigger impact.

Pros:

  • Can create Speed Nodes.
  • Can create Cost Nodes.
  • Have Far Sight
  • Can use Greater Resin Surge
  • "tacklestrength_max" is increased from 6 to 7.
  • Phermones Tier: Strong.
  • Max of 12 Nodes sustained at same time (6 per Node type)

Cons:

  • Cannot Build Resin structures.
  • Its dependant on other builder castes.
  • -80 Health. (470hp)
  • -50% plasma pool. (500p)
  • can only "Design" on weeds
  • Slower plasma gain (4.5 instead of 5.5)

Video and Photos

Screenshots & Videos
2024-12-27.15-23-06.mp4

Changelog

🆑 Venuska1117
add: Add New Hivelord strain: Designer
/:cl:

@cmss13-ci cmss13-ci bot added Sprites Remove the soul from the game. Feature Feature coder badge labels Nov 29, 2024
@Venuska1117 Venuska1117 marked this pull request as draft November 29, 2024 21:04
@Venuska1117 Venuska1117 changed the title New Hivelord Strain: Designer Hivelord Strain: Designer Nov 29, 2024
@Venuska1117 Venuska1117 force-pushed the hivelord-designer-strain branch from 2650e3f to 3876c0f Compare December 8, 2024 16:59
@cm13-github
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@cm13-github cm13-github added the Merge Conflict PR can't be merged because it touched too much code label Dec 10, 2024
@cm13-github
Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

@cm13-github cm13-github removed the Merge Conflict PR can't be merged because it touched too much code label Dec 10, 2024
@cm13-github cm13-github added the Merge Conflict PR can't be merged because it touched too much code label Dec 10, 2024
@cm13-github
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

- Added hivelord description and flavor text.
- Added Animations for weeds building.
- Added New icons for Abilities.
cleaned some code.
@Venuska1117 Venuska1117 marked this pull request as ready for review December 11, 2024 01:54
@cm13-github cm13-github removed the Merge Conflict PR can't be merged because it touched too much code label Dec 11, 2024
@Venuska1117 Venuska1117 marked this pull request as draft December 22, 2024 18:44
@Venuska1117 Venuska1117 marked this pull request as ready for review December 23, 2024 11:26
Copy link

@PhantornRU PhantornRU left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So many spaceeees...

Your code blocks are the same and are a continuation of its execution. There is no need to separate them in such cases, otherwise it creates unnecessary ladders.
Use divisions when you need to specifically separate code blocks indicating the execution of different operations.
I.e.: If you do something with animation, then you have a whole block of code for animation, you should not separate it into pieces and separate lines.
It is the same with checks.

Copy link

@PhantornRU PhantornRU left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Length() better then .len

Copy link

@PhantornRU PhantornRU left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OOP...

@Venuska1117 Venuska1117 marked this pull request as draft December 27, 2024 13:38
@Venuska1117 Venuska1117 marked this pull request as ready for review December 29, 2024 10:33
@PhantornRU
Copy link

out-of-date

@Venuska1117 Venuska1117 marked this pull request as draft January 5, 2025 19:08
@Venuska1117 Venuska1117 force-pushed the hivelord-designer-strain branch from 0145806 to c23ff96 Compare January 5, 2025 20:13
@Venuska1117 Venuska1117 force-pushed the hivelord-designer-strain branch from 1d3ef0c to c9ee1f3 Compare January 5, 2025 20:42
@Venuska1117
Copy link
Contributor Author

out-of-date

done.

@Venuska1117 Venuska1117 marked this pull request as ready for review January 5, 2025 20:44
@cm13-github cm13-github added the Merge Conflict PR can't be merged because it touched too much code label Jan 10, 2025
@cm13-github
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@cm13-github cm13-github removed the Merge Conflict PR can't be merged because it touched too much code label Jan 11, 2025
@cm13-github
Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

Copy link
Contributor

@kiVts kiVts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably missed something, not cooking today.

@@ -7,6 +7,7 @@
desc = "Weird black weeds..."
icon = 'icons/mob/xenos/weeds.dmi'
icon_state = "base"
var/icon_state_weeds //Change icon_state for weeds/node subtype.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

new var definition after overrides

return ..()

/datum/action/xeno_action/activable/design_cost_node/proc/remove_oldest_cost_node(mob/living/carbon/xenomorph/xeno)
if(xeno.cost_node_list.len > 0)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unresolved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Feature coder badge Sprites Remove the soul from the game.
Projects
Status: Changes Requested
Development

Successfully merging this pull request may close these issues.

4 participants