Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes corpse's broken paygrades, and a couple others #7973

Merged
merged 1 commit into from
Jan 4, 2025

Conversation

realforest2001
Copy link
Member

@realforest2001 realforest2001 commented Jan 1, 2025

About the pull request

As title

Explain why it's good for the game

Seeing corpses, and particularly seeing a pizza fellow, come up as ??? was annoying, and my fault.

Testing Photographs and Procedure

Screenshots & Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑
fix: Preset corpses and pizza ERTs now have correct paygrade displays.
/:cl:

@cmss13-ci cmss13-ci bot added the Fix Fix one bug, make ten more label Jan 1, 2025
@Drulikar
Copy link
Contributor

Drulikar commented Jan 1, 2025

Any preference for it how #7965 is doing it or? Both prs are tackling the same thing.

@realforest2001
Copy link
Member Author

realforest2001 commented Jan 2, 2025

Any preference for it how #7965 is doing it or? Both prs are tackling the same thing.

Only that this is broader in terms of giving corpses that would have specific titles the relevant ones. It's not a significant difference though.
Other PR also doesn't fix corpses

Copy link
Member

@fira fira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not just do both? It's simpler.

@hry-gh hry-gh added this pull request to the merge queue Jan 4, 2025
Merged via the queue into cmss13-devs:master with commit 6508634 Jan 4, 2025
29 checks passed
cmss13-ci bot added a commit that referenced this pull request Jan 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fix Fix one bug, make ten more
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants