Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Xenomorph Endgame changes #8026

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

Git-Nivrak
Copy link
Contributor

@Git-Nivrak Git-Nivrak commented Jan 6, 2025

About the pull request

  1. Added a preference for being chosen as King, under special role candidacy. You will no longer be prompted on whether you'd like to be King or not.
  2. The King hatchery now spawns around the hive core (make sure you have enough space!), Destroying a pylon will now only pause the timer, in order to fully reset it you will have to destroy the hatchery itself.
  3. Replaced the armor hive buffs with two new hive buffs: Boon of fire resistance - Makes all xenomorph immune to being ignited (you still take damage walking over fire), Boon of adaptability - Grants all xenomorphs a new ability "Transmute" (will appear under aliens tab) which allows them to change to a different caste of the same tier.

Explain why it's good for the game

  1. Added a preference for being chosen as King, under special role candidacy. You will no longer be prompted on whether you'd like to be King or not.

qol

  1. The King hatchery now spawns around the hive core (make sure you have enough space!), Destroying a pylon will now only pause the timer, in order to fully reset it you will have to destroy the hatchery itself.

Makes it more in-line with nuke, should reduce cat and mouse and actually end the round faster

  1. Replaced the armor hive buffs with two new hive buffs: Boon of fire resistance - Makes all xenomorph immune to being ignited (you still take damage walking over fire), Boon of adaptability - Grants all xenomorphs a new ability "Transmute" (will appear under aliens tab) which allows them to change to a different caste of the same tier.

Replacing the pure stat hive buffs has been a goal for me for a while, Will have to see how these new buffs perform and adjust accordingly

Testing Photographs and Procedure

Screenshots & Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑
qol: Added a preference on whether you would like to be chosen as King or not, you will no longer receive a prompt asking you for that. This can be toggled under "special role candidacy"
balance: The King hatchery now spawns around the hive core. Destroying pylons will no longer destroy the hatchery but will instead pause its progress. To fully reset the progress you must destroy the hatchery itself.
add: Replaced the armor hive buffs with two new hive buffs: Buff of Fire Resistance - Makes all xenomorph immune to being ignited by fire. Buff of Adaptability - Gives all xenomorph a new verb under the alien tab named "Transmute" which will allow them to change to a different caste of the same tier.
/:cl:

@cmss13-ci cmss13-ci bot added Quality of Life Make the game harder to play Balance You need to be a professional veteran game maintainer to comprehend what is being done here. Feature Feature coder badge labels Jan 6, 2025
@Diegoflores31
Copy link
Contributor

Diegoflores31 commented Jan 6, 2025

while you are at it if you can somehow make it so you can revert a strain if you have more than 100 evo it would be pretty neat
( not as a boon but as a normal thing)

@Red-byte3D
Copy link
Contributor

while you are at it if you can somehow make it so you can revert a strain if you have more than 100 evo it would be pretty neat ( not as a boon but as a normal thing)

#7841

@Red-byte3D
Copy link
Contributor

I was originally going to also add a 0 cost 5-15 minute QM scan (1 pylon) but i had stuff come up, maybe add that in if you want to

code/modules/mob/living/carbon/xenomorph/Evolution.dm Outdated Show resolved Hide resolved
code/modules/mob/living/carbon/xenomorph/Evolution.dm Outdated Show resolved Hide resolved
code/modules/mob/living/carbon/xenomorph/Evolution.dm Outdated Show resolved Hide resolved
code/modules/mob/living/carbon/xenomorph/Evolution.dm Outdated Show resolved Hide resolved
code/modules/mob/living/carbon/xenomorph/Evolution.dm Outdated Show resolved Hide resolved
code/modules/cm_aliens/XenoStructures.dm Outdated Show resolved Hide resolved
@harryob harryob marked this pull request as draft January 13, 2025 15:14
Copy link
Member

@harryob harryob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what red said

@Git-Nivrak Git-Nivrak marked this pull request as ready for review January 13, 2025 15:46
Copy link
Member

@harryob harryob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise fine

code/modules/cm_aliens/XenoStructures.dm Show resolved Hide resolved
@harryob harryob marked this pull request as draft January 13, 2025 17:25
@Git-Nivrak Git-Nivrak marked this pull request as ready for review January 13, 2025 17:40
Copy link
Contributor

@Drulikar Drulikar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't look tested.

code/modules/cm_aliens/XenoStructures.dm Outdated Show resolved Hide resolved
code/modules/cm_aliens/XenoStructures.dm Show resolved Hide resolved
code/modules/cm_aliens/XenoStructures.dm Outdated Show resolved Hide resolved
code/modules/cm_aliens/XenoStructures.dm Outdated Show resolved Hide resolved
@Drulikar Drulikar marked this pull request as draft January 16, 2025 01:33
@Drulikar Drulikar added the Needs Testing Need to test it on the guinea pigs (production server) label Jan 16, 2025
@Git-Nivrak Git-Nivrak marked this pull request as ready for review January 16, 2025 05:28
code/modules/cm_aliens/hivebuffs/hivebuff.dm Show resolved Hide resolved
code/modules/cm_aliens/hivebuffs/hivebuff.dm Show resolved Hide resolved
code/modules/client/preferences_toggles.dm Show resolved Hide resolved
code/modules/cm_aliens/XenoStructures.dm Show resolved Hide resolved
code/modules/mob/living/carbon/xenomorph/Evolution.dm Outdated Show resolved Hide resolved
code/modules/mob/living/carbon/xenomorph/Evolution.dm Outdated Show resolved Hide resolved
code/modules/cm_aliens/hivebuffs/hivebuff.dm Outdated Show resolved Hide resolved
@Drulikar Drulikar marked this pull request as draft January 17, 2025 05:13
@Git-Nivrak Git-Nivrak marked this pull request as ready for review January 17, 2025 05:53
@cm13-github
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@cm13-github cm13-github added the Merge Conflict PR can't be merged because it touched too much code label Jan 17, 2025
@cmss13-ci cmss13-ci bot added the Sprites Remove the soul from the game. label Jan 17, 2025
@cm13-github
Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

@cm13-github cm13-github removed the Merge Conflict PR can't be merged because it touched too much code label Jan 17, 2025
Copy link
Contributor

@Drulikar Drulikar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have any more time right now to test in game to see if there's anything else.

code/modules/cm_aliens/hivebuffs/hivebuff.dm Outdated Show resolved Hide resolved
code/modules/cm_aliens/hivebuffs/hivebuff.dm Show resolved Hide resolved
@Drulikar Drulikar added the Testmerge Candidate we'll test this while you're asleep and the server has 10 players label Jan 19, 2025
@Blundir Blundir added the Sprites Approved confirmed no stray pixels label Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Balance You need to be a professional veteran game maintainer to comprehend what is being done here. Feature Feature coder badge Needs Testing Need to test it on the guinea pigs (production server) Quality of Life Make the game harder to play Sprites Approved confirmed no stray pixels Sprites Remove the soul from the game. Testmerge Candidate we'll test this while you're asleep and the server has 10 players
Projects
Status: Changes Requested
Development

Successfully merging this pull request may close these issues.

7 participants