Fixes Inconsistent Synth Maintenance Stations Icons #8153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmss13-ci
bot
added
Sprites
Drulikar
changed the title
|
Thx for title edit, Drulikar |
harryob
requested changes
Jan 23, 2025
Co-authored-by: harryob <[email protected]>
Ultimate-Fluff
changed the title
harryob
approved these changes
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the pull request
This whole thing was a mess. Drathek and the coding community helped me put this together.
I had not experienced the issue where the Synthetic Maintenance System's icon state does not change properly when occupied and whether or not an APC is present, but investigating #4546 led me down a rabbit hole that resulted in me fixing several unrelated problems, mentioned in the changelog.
Just to be safe, however, the Synthetic Maintenance System now automatically spits somebody out if it has 0 charge under any circumstance and it refuses entry until it has some charge again. It needs a powered APC to charge, anyway, so...
Explain why it's good for the game
Fixes #4546
Testing Photographs and Procedure
Screenshots & Videos
This maintenance station has no APC powering it and it has 0 charge. It flashes red to let you know it's completely fucked.
This maintenance station has no APC powering it but it has a little bit of charge left, so the light is still green.
Changelog
🆑
imageadd: Synthetic Maintenance Stations now blink red if they cannot be operated under any circumstances.
imageadd: Synthetic Maintenance Stations flash green whether or not an APC is powering it to indicate it can still operate with charge.
fix: Synthetic Maintenance Stations now properly display the correct occupied icon state whether or not there is an APC powering the machine whilst somebody is inside.
code: Fixed and added code that makes Synthetic Maintenance Stations automatically eject patients if they run out of charge while operating.
code: Added code that disables patients from entering the Synthetic Maintenance Station if it has no charge left.
/:cl: