-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Support for Distributions in Templated Workloads #385
Merged
bpkroth
merged 36 commits into
cmu-db:main
from
ETHenzlere:feature/templated-distributions
Mar 25, 2024
Merged
Feat: Support for Distributions in Templated Workloads #385
bpkroth
merged 36 commits into
cmu-db:main
from
ETHenzlere:feature/templated-distributions
Mar 25, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/main/java/com/oltpbenchmark/benchmarks/templated/procedures/GenericQuery.java
Outdated
Show resolved
Hide resolved
src/main/java/com/oltpbenchmark/benchmarks/templated/procedures/GenericQuery.java
Outdated
Show resolved
Hide resolved
src/main/java/com/oltpbenchmark/benchmarks/templated/procedures/GenericQuery.java
Outdated
Show resolved
Hide resolved
src/main/java/com/oltpbenchmark/benchmarks/templated/procedures/GenericQuery.java
Outdated
Show resolved
Hide resolved
bpkroth
reviewed
Nov 14, 2023
src/main/java/com/oltpbenchmark/benchmarks/templated/procedures/GenericQuery.java
Outdated
Show resolved
Hide resolved
bpkroth
reviewed
Nov 14, 2023
bpkroth
reviewed
Nov 14, 2023
src/main/java/com/oltpbenchmark/benchmarks/templated/procedures/GenericQuery.java
Outdated
Show resolved
Hide resolved
bpkroth
reviewed
Nov 14, 2023
src/main/java/com/oltpbenchmark/benchmarks/templated/procedures/GenericQuery.java
Outdated
Show resolved
Hide resolved
bpkroth
reviewed
Nov 14, 2023
src/main/java/com/oltpbenchmark/benchmarks/templated/util/GenericQueryOperation.java
Outdated
Show resolved
Hide resolved
bpkroth
reviewed
Nov 14, 2023
ETHenzlere
commented
Nov 17, 2023
src/main/java/com/oltpbenchmark/benchmarks/templated/procedures/GenericQuery.java
Outdated
Show resolved
Hide resolved
src/main/java/com/oltpbenchmark/benchmarks/templated/util/ComplexValue.java
Outdated
Show resolved
Hide resolved
src/main/java/com/oltpbenchmark/benchmarks/templated/util/ComplexValue.java
Outdated
Show resolved
Hide resolved
src/main/java/com/oltpbenchmark/benchmarks/templated/util/ComplexValue.java
Outdated
Show resolved
Hide resolved
src/main/java/com/oltpbenchmark/benchmarks/templated/util/ComplexValue.java
Outdated
Show resolved
Hide resolved
src/main/java/com/oltpbenchmark/api/templates/TemplatesType.java
Outdated
Show resolved
Hide resolved
bpkroth
reviewed
Dec 1, 2023
bpkroth
reviewed
Jan 24, 2024
bpkroth
reviewed
Jan 24, 2024
bpkroth
reviewed
Jan 24, 2024
src/main/java/com/oltpbenchmark/benchmarks/templated/procedures/GenericQuery.java
Outdated
Show resolved
Hide resolved
bpkroth
reviewed
Jan 24, 2024
src/main/java/com/oltpbenchmark/benchmarks/templated/util/TemplatedValue.java
Outdated
Show resolved
Hide resolved
bpkroth
reviewed
Jan 24, 2024
src/main/java/com/oltpbenchmark/benchmarks/templated/procedures/GenericQuery.java
Outdated
Show resolved
Hide resolved
bpkroth
reviewed
Jan 24, 2024
src/main/java/com/oltpbenchmark/benchmarks/templated/procedures/GenericQuery.java
Show resolved
Hide resolved
bpkroth
reviewed
Jan 24, 2024
src/main/java/com/oltpbenchmark/benchmarks/templated/procedures/GenericQuery.java
Show resolved
Hide resolved
Looking pretty good. Just a few cosmetic polish things left:
|
bpkroth
reviewed
Mar 14, 2024
src/main/java/com/oltpbenchmark/benchmarks/templated/util/TemplatedValue.java
Outdated
Show resolved
Hide resolved
bpkroth
reviewed
Mar 14, 2024
src/main/java/com/oltpbenchmark/benchmarks/templated/util/TemplatedValue.java
Outdated
Show resolved
Hide resolved
bpkroth
reviewed
Mar 20, 2024
src/main/java/com/oltpbenchmark/benchmarks/templated/util/TemplatedValue.java
Outdated
Show resolved
Hide resolved
bpkroth
reviewed
Mar 20, 2024
bpkroth
reviewed
Mar 20, 2024
bpkroth
approved these changes
Mar 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR adds support for various Numerical Distributions in templated benchmarks
The distributions work not only for integers, but also different types such as timestamps, long, float
A table of supported combinations can be found in the templated benchmarks readme.
Usage example:
This PR is not a breaking change - One can still use a static value in the templated queries.
<value>10</value>
In the future, I could see a breaking change that adds the datatype directly to the values so the TemplatedValue can do the type handling directly.
<value dist="uniform" type="integer">
. This would make type checking easier and remove the need to store the original min/max values as strings for all datatypes.