-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: fetch
by default
#156
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dshemetov
force-pushed
the
ds/merge-fetch
branch
from
August 26, 2023 00:34
2b982aa
to
65a3736
Compare
Generally pretty happy with this, made a number of small docs changes. To keep the format of the flags the same (i.e. they're all off by default), maybe I separated |
dsweber2
force-pushed
the
ds/merge-fetch
branch
from
August 29, 2023 22:02
2295150
to
25dc373
Compare
dsweber2
force-pushed
the
ds/merge-fetch
branch
from
August 29, 2023 22:06
25dc373
to
b3cbd5d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #144
closes #119
fetch_args_list()
has these arguments, open to better/clearer naming suggestswith_base_url
sounds like it follows the withr/etc. pattern but doesn't #82TODO: