implemented correct k8s validation #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zvonkok
commented
Jun 5, 2024
| serde_json = "1.0" | ||
| jsonschema = "0.18.0" | ||
| once_cell = "1.8.0" | ||
| notify = "6.1.1" | ||
| serde = "1.0.131" | ||
| serde_derive = "1.0.131" | ||
| libc = "0.2.112" | ||
| nix = "0.29.0" | ||
| nix = "0.24.2" |
There was a problem hiding this comment.
Downgrade for kata-agent build
zvonkok
commented
Jun 5, 2024
| lazy_static = "1.2" | ||
| path-clean = "1.0.1" | ||
| serde_yaml = "0.9.33" | ||
| semver = "1.0.23" |
There was a problem hiding this comment.
Downgrade for kata-agent build
zvonkok
commented
Jun 5, 2024
| assert!(parse_annotations(cdi_devices.clone()).is_ok()); | ||
| let (keys, devices) = parse_annotations(cdi_devices).unwrap(); | ||
| assert!(parse_annotations(&cdi_devices).is_ok()); | ||
| let (keys, devices) = parse_annotations(&cdi_devices).unwrap(); |
There was a problem hiding this comment.
Reference for using in kata-agent we do not need to own the annotations.
zvonkok
commented
Jun 5, 2024
| assert!(validate_annotations(&large_annotations, path).is_err()); | ||
|
|
||
| let mut invalid_annotations = BTreeMap::new(); | ||
| invalid_annotations.insert("inv$$alid_CDIKEY".to_string(), "inv$$alid_CDIVAL".to_string()); |
There was a problem hiding this comment.
invalid_CDIKEY is actually a valid name, added $$ which is not valid
Apokleos
reviewed
Jun 6, 2024
Signed-off-by: Zvonko Kaiser <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.