Add oci opts #6
Merged
Add oci opts #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(1) As cdi spec will be involved in some other files, we need make it and its related fields public. (2) Change annotations: HashMap to BTreeMap, as the object of Spec will be involved in HashSet with cmp hash value in Cache. But HashMap has no impl for trait Hash. (3) Others,such as Mount.mount_type to r#type, and the type of DeviceNode.file_mode as Option<mode_t> Signed-off-by: Alex Lyn <[email protected]>
As original mod.rs where cdi spec defined, I think we should move it to a dedicated config.rs for CDI spec which ensures adherence to Rust style and keep maintaining alignment with cdi-go code for specs-go. Fixes cncf-tags#5 Signed-off-by: Alex Lyn <[email protected]>
Add to_oci() opts for CDI Hook, Mount, DeviceNode and InteRdt Signed-off-by: Alex Lyn <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add to_oci opts for CDI Hook, Mount, DeviceNode and IntelRdt