Add container edits and related members #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Apokleos
commented
May 24, 2024
Apokleos
commented
- Add ContainerEdits and implement its related methods;
- Add other related members of ContainerEdits, such as DeviceNode, Mount, Hook and so on.
- Implement fill_missing_info for DeviceNode
add structure ContainerEdits and impl it with important methods Signed-off-by: Alex Lyn <[email protected]>
Add other members of CDI ContainerEdits, such as DeviceNode, Hook, Mount and IntelRdt. Add trait Validate and impl it for each member. Signed-off-by: Alex Lyn <[email protected]>
Implement fill_missing_info for DeviceNode and add UT. Signed-off-by: Alex Lyn <[email protected]>
|
Hi @zvonkok PTAL Thank you! |
|
We're getting into a state where we need to think about GHA! I will add a GPU machine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.