Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update proposal 2 with design changes #143

Merged
merged 1 commit into from
Jan 21, 2025

Conversation

rossf7
Copy link
Contributor

@rossf7 rossf7 commented Dec 4, 2024

What type of PR is this?

kind/documentation

What this PR does / why we need it:

Updates proposal 2 with design changes implemented in #127

Which issue(s) this PR fixes:

Fixes #117

Special notes for your reviewer (optional):

Changes are quite big so sorry the diff is hard to follow.
I also changed the diagram to mermaid based on the diagram @dipankardas011 added to proposal 1.

@rossf7 rossf7 requested a review from a team as a code owner December 4, 2024 12:39
@rossf7 rossf7 enabled auto-merge (rebase) December 4, 2024 12:55
@rossf7 rossf7 disabled auto-merge December 4, 2024 12:56
Copy link
Contributor

@dipankardas011 dipankardas011 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

apart from the above comment LGTM

@rossf7 rossf7 closed this Dec 8, 2024
@rossf7 rossf7 deleted the docs/prop-3-updates branch December 8, 2024 13:56
@rossf7 rossf7 restored the docs/prop-3-updates branch December 9, 2024 09:02
@rossf7
Copy link
Contributor Author

rossf7 commented Dec 9, 2024

Sorry I closed the wrong PR 🤦‍♂️

@rossf7 rossf7 reopened this Dec 9, 2024
Copy link
Contributor

@nikimanoledaki nikimanoledaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you @rossf7 !!

@rossf7 rossf7 merged commit db273b5 into cncf-tags:main Jan 21, 2025
1 check passed
@rossf7 rossf7 deleted the docs/prop-3-updates branch January 21, 2025 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[TRACKING] Implement Proposal 2: Run
3 participants