-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding CSNC takeover example #861
Conversation
Signed-off-by: James Hunt <[email protected]>
I think whenever we use the hero takeover technique, we should switch the hello bar to not show on the homepage, as we had for the Kubecon takeover. On my screen this new hero is quite a bit longer than the normal one. The "REGISTER NOW" button is on the fold line. Even if we remove the hello bar, I still think it's a bit long. Could we match the normal hero height? I'm not sure I love the purple overlay. It may look better in a darker shade but we could get other opinions. |
Sure, we can update any options, I didn't edit them this just came over in the setup of the dev env
This is caused by the height of the CNSC logo - can you inspect element and see if there is a height of it where it still looks good and not too small and if that fixes your issue? |
Maybe try these adjustment from what you have?
|
Signed-off-by: James Hunt <[email protected]>
I felt the CNSC logo was too close to the top which is why I didn't want to edit that top spacing. But have implemented. I would like to put forward the hero colour as is. It's a takeover. It needs to look substantially different to the current and your suggestion does not. |
Signed-off-by: James Hunt <[email protected]>
Let's keep this open for when we do the takeover for Kubecon NA #831 |
I've taken what I need form this PR to include in #879, specifically splitting out the takeover hero as a separate file to make it easier to use going forward. |
home-hero-guest
.PR - https://pr-861-cncfci.pantheonsite.io