Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding CSNC takeover example #861

Closed
wants to merge 3 commits into from
Closed

Adding CSNC takeover example #861

wants to merge 3 commits into from

Conversation

thetwopct
Copy link
Collaborator

@thetwopct thetwopct commented Jun 16, 2024

  • Uses latest video from Erik using CNSC footage
  • Adds a new file to handle takeover data so we do not have to start from scratch or revert each time - home-hero-guest.
  • Adds new promotions folder to images that stores video and poster images

PR - https://pr-861-cncfci.pantheonsite.io

Screenshot-2024-06-16 --15 43 24

@cjyabraham
Copy link
Collaborator

I think whenever we use the hero takeover technique, we should switch the hello bar to not show on the homepage, as we had for the Kubecon takeover.

On my screen this new hero is quite a bit longer than the normal one. The "REGISTER NOW" button is on the fold line. Even if we remove the hello bar, I still think it's a bit long. Could we match the normal hero height?

I'm not sure I love the purple overlay. It may look better in a darker shade but we could get other opinions.

@thetwopct
Copy link
Collaborator Author

thetwopct commented Jun 17, 2024

I think whenever we use the hero takeover technique, we should switch the hello bar to not show on the homepage

Sure, we can update any options, I didn't edit them this just came over in the setup of the dev env

Could we match the normal hero height?

This is caused by the height of the CNSC logo - can you inspect element and see if there is a height of it where it still looks good and not too small and if that fixes your issue?

@cjyabraham
Copy link
Collaborator

Maybe try these adjustment from what you have?

.takeover-logo {
    margin-top: min(36%, 50px);
}

.home-hero__metric_wrapper {
    margin-bottom: min(20%, 70px);
}

Signed-off-by: James Hunt <[email protected]>
@cjyabraham
Copy link
Collaborator

Also, I tried this for the overlay and think it looks better... not such an overwhelm of purple: #342645bf

Screenshot 2024-06-17 at 11 40 31 AM

@thetwopct
Copy link
Collaborator Author

I felt the CNSC logo was too close to the top which is why I didn't want to edit that top spacing. But have implemented.

I would like to put forward the hero colour as is. It's a takeover. It needs to look substantially different to the current and your suggestion does not.

@cjyabraham
Copy link
Collaborator

Let's keep this open for when we do the takeover for Kubecon NA #831

@cjyabraham cjyabraham mentioned this pull request Jul 1, 2024
7 tasks
@cjyabraham
Copy link
Collaborator

I've taken what I need form this PR to include in #879, specifically splitting out the takeover hero as a separate file to make it easier to use going forward.

@cjyabraham cjyabraham closed this Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants